Merge pull request #165 from tle-bdc/bug/BDC-70000

BDC-70000 Fix null pointer exception
intuit · Aug 11, 2021 · f61d04d · f61d04d
2 parents b3212eb + 1b1a539
commit f61d04d
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/ipp-v3-java-devkit/src/main/java/com/intuit/ipp/interceptors/HandleResponseInterceptor.java b/ipp-v3-java-devkit/src/main/java/com/intuit/ipp/interceptors/HandleResponseInterceptor.java
@@ -104,19 +104,19 @@ public void execute(IntuitMessage intuitMessage) throws FMSException {
 		if (intuitResponse != null && intuitResponse.getFault() != null) {
 			Fault fault = intuitResponse.getFault();
 
-			if (fault.getType().equalsIgnoreCase("Validation")) {
+			if ("Validation".equalsIgnoreCase(fault.getType())) {
 				throw new ValidationException(fault.getError());
-			} else if (fault.getType().equalsIgnoreCase("Service")) {
+			} else if ("Service".equalsIgnoreCase(fault.getType())) {
 				throw new ServiceException(fault.getError());
-			} else if (fault.getType().equalsIgnoreCase("AuthenticationFault")) {
+			} else if ("AuthenticationFault".equalsIgnoreCase(fault.getType())) {
 				throw new AuthenticationException(fault.getError());
-			} else if (fault.getType().equalsIgnoreCase("Authentication")) {
+			} else if ("Authentication".equalsIgnoreCase(fault.getType())) {
 				throw new AuthenticationException(fault.getError());
-			} else if (fault.getType().equalsIgnoreCase("ApplicationAuthenticationFailed")) {
+			} else if ("ApplicationAuthenticationFailed".equalsIgnoreCase(fault.getType())) {
 				throw new AuthenticationException(fault.getError());
-			} else if (fault.getType().equalsIgnoreCase("Authorization")) {
+			} else if ("Authorization".equalsIgnoreCase(fault.getType())) {
 				throw new AuthorizationException(fault.getError());
-			} else if (fault.getType().equalsIgnoreCase("AuthorizationFault")) {
+			} else if ("AuthorizationFault".equalsIgnoreCase(fault.getType())) {
 				throw new AuthorizationException(fault.getError());
 			} else {
 				//not able to recognize the type of exception