Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake version range #304

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

philippewarren
Copy link
Contributor

No description provided.

@philippewarren philippewarren requested a review from doumdi December 5, 2024 14:09
@philippewarren philippewarren changed the base branch from master to ros2-migration December 5, 2024 14:09
@philippewarren philippewarren merged commit 3cb1c03 into ros2-migration Dec 5, 2024
4 checks passed
@philippewarren philippewarren deleted the fix-cmake-version-range branch December 5, 2024 14:52
@doumdi
Copy link
Member

doumdi commented Dec 5, 2024

@philippewarren
Can we do better with max version of cmake, it seems that it could be a problem in the future ?

@philippewarren
Copy link
Contributor Author

@philippewarren Can we do better with max version of cmake, it seems that it could be a problem in the future ?

It's mostly a promise to CMake that it works at least until the specified version of CMake. I don't think we'll have any problems in the future du to this, as is does not mean that CMake versions above this will not work or anything like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants