Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING doc #4

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Add CONTRIBUTING doc #4

merged 2 commits into from
Mar 12, 2021

Conversation

thibmaek
Copy link
Contributor

Adding a contributing doc in the correct location will make Github highlight this document to first-time contributors:
(+ it's also more widely expected than linking to an external site)

More: https://docs.github.com/en/github/building-a-strong-community/setting-guidelines-for-repository-contributors


Our code formatting rules are defined in [.eslintrc.js](https://github.com/inthepocket/cookie-though/blob/master/.eslintrc.js). You can check your code against these standards by running:

```console
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the correct language for console entries is console, not sh which means the sh shell specifically or sh scripts.

@gboston
Copy link
Contributor

gboston commented Mar 12, 2021

We first need to have #3

@Klukies
Copy link
Member

Klukies commented Mar 12, 2021

Maybe it would be better if we would refer to this document from the README.md file as well then?
We could leave the contributing file in the docs, but it might be better to keep everything on the GitHub domain as you stated.

@thibmaek
Copy link
Contributor Author

Maybe it would be better if we would refer to this document from the README.md file as well then?

Indeed, much like things like standard-readme define: https://github.com/RichardLitt/standard-readme

We could leave the contributing file in the docs,

That won't make Github highlight it, unless it lives top-level in your docs folder.

@Klukies
Copy link
Member

Klukies commented Mar 12, 2021

Yes, then I would suggest changing the link in README.md to the contributing file you've added in this PR!
I still think it's useful for it to live on the docs as well, but the benefits you've pointed out are clear.

@thibmaek thibmaek merged commit c03bcc2 into master Mar 12, 2021
@thibmaek thibmaek deleted the feature/add-contributing branch March 12, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants