deps: ngx-custom-validators instead of ng2-validations #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for your contribution! |
shauke
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
While upgrading to Angular 9 within the PWA upgrade to 0.20 I faced the following bug while running
npm iSymbol Base64Validator declared in /node_modules/ng2-validation/dist/base64/directive.js is not exported from /node_modules/ng2-validation/dist/base64/directive (import into /node_modules/ng2-validation/dist/index.js)Issue Number: Closes #286
What Is the New Behavior?
Install the new dependency and change the import of
ng2-validationtongx-custom-validators, the latter has been forked from the original one and supports Angular 9.Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information