fixed show auction action issue

app/controllers/admin/auctions_controller.rb

@@ -80,7 +80,7 @@ def apply_auction_participants
       auction = Auction.find_by_uuid(params[:auction_uuid])
       users = User.where(id: params[:user_ids])
       users.each do |user|
-        DomainParticipateAuction.create!(user: user, auction: auction)
+        DomainParticipateAuction.create!(user:, auction:)
       end
 
       redirect_to admin_auction_path(auction)

app/controllers/auctions_controller.rb

@@ -8,10 +8,13 @@ class AuctionsController < ApplicationController
   def index
     set_cors_header
     @auctions_list = fetch_auctions_list
-    per_page = params[:per_page] || per_page_count
     @pagy, @auctions = pagy(@auctions_list, items: per_page, link_extra: 'data-turbo-action="advance"')
   end
 
+  def show
+    redirect_to root_path, status: :moved_permanently
+  end
+
   # OPTIONS /auctions
   def cors_preflight_check
     set_access_control_headers
@@ -33,8 +36,12 @@ def should_sort_auctions?
     params[:sort_by].blank? && params[:sort_direction].blank?
   end
 
+  def per_page
+    params[:per_page] || DEFAULT_PAGE_LIMIT
+  end
+
   def per_page_count
-    count = params[:show_all] == 'true' ? @auctions_list.count : DEFAULT_PAGE_LIMIT
+    count = params[:show_all] == 'true' ? @auctions_list.count : per_page
     count = nil if count.zero?
     count
   end

app/controllers/english_offers_controller.rb

@@ -56,13 +56,13 @@ def show
   # GET /english_offers/aa450f1a-45e2-4f22-b2c3-f5f46b5f906b/edit
   def edit
     @auction = @offer.auction
-    redirect_to auction_path(@auction.uuid) and return if update_not_allowed(@auction)
+    redirect_to root_path and return if update_not_allowed(@auction)
   end
 
   # PUT /english_offers/aa450f1a-45e2-4f22-b2c3-f5f46b5f906b
   def update
     @auction = Auction.english.with_user_offers(current_user.id).find_by(uuid: @offer.auction.uuid)
-    redirect_to auction_path(@auction.uuid) and return if update_not_allowed(@auction)
+    redirect_to root_path and return if update_not_allowed(@auction)
     inform_invalid_captcha and return unless recaptcha_valid
 
     if update_predicate(@auction)

app/models/billing_profile.rb

@@ -19,7 +19,7 @@ class BillingProfile < ApplicationRecord
   has_many :domain_offer_histories
   has_many :invoices
 
-  scope :with_search_scope, ->(origin) {
+  scope :with_search_scope, lambda { |origin|
     if origin.present?
       joins(:user)
         .includes(:user)
@@ -39,10 +39,12 @@ def self.search(params = {})
 
   def vat_code_must_be_registered_in_vies
     # Vat code validation only for EU countries
-    vat_rate = Countries.vat_rate_from_alpha2_code(self.country_code)
+    vat_rate = Countries.vat_rate_from_alpha2_code(country_code)
     return if vat_code.blank? || vat_rate == BigDecimal(0)
 
-    errors.add(:vat_code, I18n.t('billing_profiles.vat_validation_error')) unless Valvat.new(self.vat_code).exists?
+    errors.add(:vat_code, I18n.t('billing_profiles.vat_validation_error')) unless Valvat.new(vat_code).exists?
+  rescue Valvat::RateLimitError
+    errors.add(:vat_code, I18n.t('billing_profiles.vat_validation_rate_limit_error'))
   end
 
   def issued_invoices
@@ -67,7 +69,7 @@ def vat_rate
       # if Time.zone.now.year < 2024
       #   return BigDecimal(OLD_EST_RATE_VAT)
       # else
-      return BigDecimal(Setting.find_by(code: :estonian_vat_rate).retrieve, 2) 
+      return BigDecimal(Setting.find_by(code: :estonian_vat_rate).retrieve, 2)
       # end
     end
 
@@ -77,11 +79,11 @@ def vat_rate
   end
 
   def self.create_default_for_user(user_id)
-    return if find_by(user_id: user_id)
+    return if find_by(user_id:)
 
     user = User.find(user_id)
 
-    billing_profile = new(user: user, country_code: user.country_code, name: user.display_name)
+    billing_profile = new(user:, country_code: user.country_code, name: user.display_name)
     billing_profile.save!
 
     billing_profile
@@ -116,11 +118,13 @@ def mirror_address_to_attached_invoices
   private
 
   def update_billing_information_for_invoices
+    return unless name_changed? || street_changed? || city_changed? || postal_code_changed? || country_code_changed?
+
     issued_invoices.update_all(
       billing_name: name,
       billing_address: address,
       billing_vat_code: vat_code,
       billing_alpha_two_country_code: alpha_two_country_code
-    ) if name_changed? || street_changed? || city_changed? || postal_code_changed? || country_code_changed?
+    )
   end
 end