generated from internetarchive/iaux-typescript-wc-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidated Item Removal process which can be used on offshoot pages. #417
Open
nsharma123
wants to merge
6
commits into
main
Choose a base branch
from
webdev-7228-reconsolidation-item-removal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3228f97
Add extra button for search page manage UI
nsharma123 92c0b12
Initial changes
nsharma123 dc33e06
Merge branch 'main' of https://github.com/internetarchive/iaux-collec…
nsharma123 e296fc6
Make dispathced content consistent
nsharma123 b464f2b
Code suggestions
nsharma123 6d71997
REmove unused properties
nsharma123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,5 @@ | ||
import { msg } from '@lit/localize'; | ||
import { | ||
LitElement, | ||
html, | ||
css, | ||
TemplateResult, | ||
CSSResultGroup, | ||
PropertyValues, | ||
} from 'lit'; | ||
import { LitElement, html, css, TemplateResult, CSSResultGroup } from 'lit'; | ||
import { customElement, property } from 'lit/decorators.js'; | ||
import { when } from 'lit/directives/when.js'; | ||
import { | ||
|
@@ -24,11 +17,6 @@ export class ManageBar extends LitElement { | |
*/ | ||
@property({ type: String }) label = msg('Select items to remove'); | ||
|
||
/** | ||
* Specifies the context in which the collection browser is being used | ||
*/ | ||
@property({ type: String }) activeTabId?: string; | ||
|
||
/** | ||
* The shared modal manager component for displaying modal dialogs on this page | ||
*/ | ||
|
@@ -39,6 +27,11 @@ export class ManageBar extends LitElement { | |
*/ | ||
@property({ type: Object }) selectedItems: Array<ManageableItem> = []; | ||
|
||
/** | ||
* Message shows as note in the modal when removing items | ||
*/ | ||
@property({ type: String }) manageViewModelMsg?: string; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just noting a possible small typo: |
||
|
||
/** | ||
* Whether to show the "Select All" button (default false) | ||
*/ | ||
|
@@ -49,11 +42,6 @@ export class ManageBar extends LitElement { | |
*/ | ||
@property({ type: Boolean }) showUnselectAll = false; | ||
|
||
/** | ||
* Whether item has deleted or not (default true) | ||
*/ | ||
@property({ type: Boolean }) hasItemsDeleted = true; | ||
|
||
/** | ||
* Whether to show "Item Manager the items" button (default false) | ||
*/ | ||
|
@@ -64,12 +52,6 @@ export class ManageBar extends LitElement { | |
*/ | ||
@property({ type: Boolean }) removeAllowed = false; | ||
|
||
updated(changed: PropertyValues): void { | ||
if (changed.has('hasItemsDeleted') && !this.hasItemsDeleted) { | ||
this.showRemoveItemsErrorModal(); | ||
} | ||
} | ||
|
||
render(): TemplateResult { | ||
return html` | ||
<div class="manage-container"> | ||
|
@@ -125,7 +107,6 @@ export class ManageBar extends LitElement { | |
} | ||
|
||
private removeItemsClicked(): void { | ||
this.showRemoveItemsProcessingModal(); | ||
this.dispatchEvent(new CustomEvent('removeItems')); | ||
} | ||
|
||
|
@@ -146,17 +127,10 @@ export class ManageBar extends LitElement { | |
* @param items Which items to list in the modal | ||
*/ | ||
private showRemoveItemsModal(): void { | ||
const delayMessage = | ||
this.activeTabId === 'uploads' | ||
? msg( | ||
'Note: it may take a few minutes for these items to stop appearing in your uploads list.' | ||
) | ||
: undefined; | ||
|
||
const customModalContent = html` | ||
<remove-items-modal-content | ||
.items=${this.selectedItems} | ||
.message=${delayMessage} | ||
.message=${this.manageViewModelMsg} | ||
@confirm=${() => this.removeItemsClicked()} | ||
></remove-items-modal-content> | ||
`; | ||
|
@@ -184,7 +158,7 @@ export class ManageBar extends LitElement { | |
/** | ||
* Shows a modal dialog indicating that item removal is being processed | ||
*/ | ||
private showRemoveItemsProcessingModal(): void { | ||
showRemoveItemsProcessingModal(): void { | ||
const config = new ModalConfig({ | ||
showProcessingIndicator: true, | ||
processingImageMode: 'processing', | ||
|
@@ -207,7 +181,7 @@ export class ManageBar extends LitElement { | |
/** | ||
* Shows a modal dialog indicating that an error occurred while removing items | ||
*/ | ||
private showRemoveItemsErrorModal(): void { | ||
showRemoveItemsErrorModal(): void { | ||
const config = new ModalConfig({ | ||
showProcessingIndicator: false, | ||
processingImageMode: 'processing', | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder not to merge the alpha version into main.