Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to new page number display format #1366

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Switch to new page number display format #1366

merged 6 commits into from
Jan 22, 2025

Conversation

pezvi
Copy link
Contributor

@pezvi pezvi commented Jan 7, 2025

  • Split desktop and mobile page number displays
  • CSS: Move 'hide' to .controls
  • Add/split tests for desktop and mobile page number displays

Switch to new page number display format
3371444 
- Split desktop and mobile page number displays
- CSS: Move 'hide' to .controls
- Add/split tests for desktop and mobile page number displays
@codecov Codecov
Copy link

codecov bot commented Jan 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@3548feb). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/BookReader/Navbar/Navbar.js 73.07% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #1366   +/-   ##
=========================================
  Coverage          ?   69.24%           
=========================================
  Files             ?       59           
  Lines             ?     5108           
  Branches          ?     1082           
=========================================
  Hits              ?     3537           
  Misses            ?     1544           
  Partials          ?       27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rebecca-shoptaw
rebecca-shoptaw approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@rebecca-shoptaw rebecca-shoptaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! So nice and clean and easy to extend 🙂

src/BookReader/Navbar/Navbar.js Show resolved Hide resolved
tests/jest/BookReader/Navbar/Navbar.test.js Show resolved Hide resolved
src/BookReader/Navbar/Navbar.js Outdated Show resolved Hide resolved
bfalling
bfalling approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@bfalling bfalling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pezvi pezvi marked this pull request as ready for review January 14, 2025 19:05
@pezvi pezvi requested a review from cdrini January 15, 2025 19:28
iisa
iisa approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@iisa iisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for tests 🎉 :lgtm:

cdrini
cdrini approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the review app in IA on a public book which has bother asserted/non-asserted, and with liner notes, and worked like a charm! 🥳 Congrats on your first PR!! 🥳 🥳 🥳 🥳

@cdrini cdrini merged commit 5c9f6d8 into master Jan 22, 2025
11 of 12 checks passed
@cdrini cdrini deleted the br-6822-update-page-number-display branch January 22, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebecca-shoptaw rebecca-shoptaw rebecca-shoptaw approved these changes

@iisa iisa iisa approved these changes

@cdrini cdrini cdrini approved these changes

@bfalling bfalling bfalling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pezvi @bfalling @cdrini @iisa @rebecca-shoptaw