Merge pull request #93 from intelowlproject/develop

3.1.4 [release]

.github/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## [3.1.4](https://github.com/intelowlproject/pyintelowl/releases/tag/3.1.4)
+* Fix `IntelOwl._get_observable_classification` not setting 'generic' classification properly.
+
 ## 3.1.3 (https://github.com/intelowlproject/pyintelowl/releases/tag/3.1.3)
 * Fix to allow SSL verification without a specified PEM file
 

docs/conf.py

@@ -13,7 +13,7 @@
 import os
 import sys
 
-VERSION = "v3.1.0"
+VERSION = "v3.1.4"
 GITHUB_URL = "https://github.com/intelowlproject/pyintelowl"
 
 sys.path.append(os.path.abspath("../"))

docs/requirements.txt

@@ -1,4 +1,4 @@
-Sphinx==3.5.4
+Sphinx==4.0.2
 sphinx-rtd-theme
 sphinxcontrib.asciinema
 sphinxcontrib-napoleon

pyintelowl/pyintelowl.py

@@ -586,7 +586,7 @@ def _new_analysis_cli(
     def _get_observable_classification(self, value: str) -> str:
         """Returns observable classification for the given value.\n
         Only following types are supported:
-        ip, domain, url, hash (md5, sha1, sha256)
+        ip, domain, url, hash (md5, sha1, sha256), generic (if no match)
 
         Args:
             value (str):
@@ -597,7 +597,7 @@ def _get_observable_classification(self, value: str) -> str:
                 if value type is not recognized
 
         Returns:
-            str: one of `ip`, `url`, `domain` or `hash`.
+            str: one of `ip`, `url`, `domain`, `hash` or 'generic'.
         """
         try:
             ipaddress.ip_address(value)
@@ -620,9 +620,9 @@ def _get_observable_classification(self, value: str) -> str:
             ):
                 classification = "hash"
             else:
-                classification = "general"
+                classification = "generic"
                 self.logger.warning(
-                    f"{value} is neither a domain nor a URL nor a IP not a hash"
+                    "Couldn't detect observable classification, setting as 'generic'..."
                 )
         else:
             # its a simple IP

pyintelowl/version.py

@@ -1 +1 @@
-__version__ = "3.1.3"
+__version__ = "3.1.4"