Adding Search component #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good 👍 |
annsonn
approved these changes
Jul 27, 2018
JLBoor
approved these changes
Jul 31, 2018
JLBoor
pushed a commit
that referenced
this pull request
Jul 31, 2018
* #6 - Added user profile component with stubbed state * #6 - Refactor to use props in user profile component * Add first hacky attempt at a search component * PA/BK Update search terms on submit and disable submit button when input field is empty * PA/BK Ignore IntelliJ folder and package-lock.json * implement-redux-for-search: hooked up a store of some sort but not sure if this is actually working as expected; will look into writing tests to verify in meantime * #10 create store for user profile with initial state (first cut) * [BK] fixed App.test, added a basic Search.test * #10 fix test * #7 wire up first cut of action for avatar * #7 Update state when user clicks make cat * Adding Search component (#9) * Add first hacky attempt at a search component * PA/BK Update search terms on submit and disable submit button when input field is empty * PA/BK Ignore IntelliJ folder and package-lock.json * Added Search component to index.js * Fixed tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Create search input component #1
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: