Add Newslist component #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You don't need to put it in it's own folder yet, you can just pull it out into its own file like 'NewsListTable.js' |
JLBoor
reviewed
Jul 24, 2018
src/App.js
Outdated
| return ( | ||
| <div> | ||
| <h1>News List</h1> | ||
| {this.state.news.map((item, index) => ( |
There was a problem hiding this comment.
It might be a good idea to create a function renderNewsList(), for instance. It's always nicer to keep the render function very simple. Easier to test too :)
|
Merging into master.. I'll keep you posted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo: add tests and pull out newslist into separate folder (not sure about folder structure for compoennts?)
PR for Issue: #2