Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report WNEGCONSTCOMP also on smaller unsigned int types #216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Report WNEGCONSTCOMP also on smaller unsigned int types #216

wants to merge 1 commit into from

Conversation

mandolaerik
Copy link
Contributor

No description provided.

@mandolaerik
Copy link
Contributor Author

This check would have captured a $this == -1 check in PCI common code, which took me some effort to track down.

@syssimics
Copy link
Contributor

Verification #12268239: pass

@mandolaerik
Copy link
Contributor Author

We could also extend the check further, to warn for < 0 and >= 0

@lwaern-intel
Copy link
Contributor

lwaern-intel commented Jun 24, 2024 •
edited
Loading

@mandolaerik oh this is awkward

uhh... I guess you can close this? Or pick it if you prefer the way it goes about it.

@mandolaerik
Copy link
Contributor Author

Right, duplicates #299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwaern-intel lwaern-intel Awaiting requested review from lwaern-intel

@JonatanWaern JonatanWaern Awaiting requested review from JonatanWaern

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mandolaerik @syssimics @lwaern-intel