Disable SM3, Bug fixes, Readme & version update.

- Disable SM3 by default due to limitation. - Fix engine issues with sm3 p_state and testapp. - Fix issue with sync qat_hw rsa. - Readme & Version Update to v0.6.11 Signed-off-by: Yogaraj Alamenda <[email protected]>
intel · Jan 27, 2022 · d995046 · d995046
1 parent d44ae7e
commit d995046
Show file tree

Hide file tree

Showing 23 changed files with 311 additions and 206 deletions.
diff --git a/configure.ac b/configure.ac
@@ -2,7 +2,7 @@
 # Process this file with autoconf to produce a configure script.
 
 AC_PREREQ([2.68])
-AC_INIT([qatengine], [0.6.10], [])
+AC_INIT([qatengine], [0.6.11], [])
 AC_CONFIG_SRCDIR([config.h.in])
 AC_CONFIG_HEADERS([config.h])
 AC_CONFIG_AUX_DIR([.])
@@ -576,15 +576,18 @@ fi
 if test "x$enable_qat_sw_sm2" != "xno" -a "x$cflags_qat_sw" != "x"
 then
   enable_qat_sw_sm2="-DENABLE_QAT_SW_SM2"
-  AC_MSG_NOTICE([Accelerating SM3 to Software (Multi-buffer)])
+  AC_MSG_NOTICE([Accelerating SM2 to Software (Multi-buffer)])
+else
+  enable_qat_sw_sm2=""
+  AC_MSG_NOTICE([Not Accelerating SM2 to Software])
 fi
 
-if test "x$enable_qat_sw_sm3" != "xno" -a "x$cflags_qat_sw" != "x"
+if test "x$enable_qat_sw_sm3" = "xyes" -a "x$cflags_qat_sw" != "x"
 then
   enable_qat_sw_sm3="-DENABLE_QAT_SW_SM3"
-  AC_MSG_NOTICE([Accelerating SM3 to Software])
+  AC_MSG_NOTICE([Accelerating SM3 to Software (experimental)])
 else
-  enable_qat_sw_sm3="-DDISABLE_QAT_SW_SM3"
+  enable_qat_sw_sm3=""
   AC_MSG_NOTICE([Not Accelerating SM3 to Software])
 fi
 

diff --git a/docs/config_options.md b/docs/config_options.md
@@ -166,10 +166,20 @@ The following is a list of the options that can be used with the
     '--enable-qat_sw' (enabled by default if qat_sw is enabled).
 
 --disable-qat_sw_ecdh/--enable-qat_sw_ecdh
-    Disable/Enable Intel(R) QAT Software ECDH P-256/P-384 acceleration.
+    Disable/Enable Intel(R) QAT Software ECDH P-256/P-384/SM2 acceleration.
     This flag is valid only when QAT SW acceleration is enabled using the flag
     '--enable-qat_sw' (enabled by default if qat_sw is enabled).
 
+--disable-qat_sw_sm2/--enable-qat_sw_sm2
+    Disable/Enable Intel(R) QAT Software ECDSA SM2 acceleration.
+    This flag is valid only when QAT SW acceleration is enabled using the flag
+    '--enable-qat_sw' (enabled by default if qat_sw is enabled).
+
+--disable-qat_sw_sm3/--enable-qat_sw_sm3
+    Disable/Enable Intel(R) QAT Software SM3 acceleration.
+    This flag is valid only when QAT SW acceleration is enabled using the flag
+    '--enable-qat_sw' (disabled by default).
+
 --disable-qat_small_pkt_offload/--enable-qat_small_pkt_offload
     Enable the acceleration of small packet cipher operations to Intel(R) QAT
     Hardware. When disabled, these operations are performed using the CPU

diff --git a/docs/features.md b/docs/features.md
@@ -30,8 +30,11 @@
     * ECDH Support for the following curves:
         * Montgomery EC Curve: X25519
         * NIST Prime Curves: P-256/P-384
+        * SM2
     * ECDSA Support for the following curves:
         * NIST Prime Curves: P-256/P-384
+        * SM2
+    * SM3 Hash Support using 16 Multibuffer requests (Experimental).
     * AES128-GCM, AES192-GCM and AES256-GCM
 
 [QAT_HW & QAT_SW Co-existence Feature](qat_hw.md#qat-hw-and-qat-sw-co-existence-feature)

diff --git a/docs/limitations.md b/docs/limitations.md
@@ -31,3 +31,8 @@
   sshd looks to be closing the file descriptors associated with QAT engine and driver
   after initialising openssl. Work around in sshd which comments out the closefrom()
   calls is needed to unblock the issue.
+* SM2 ECDH and ECDSA application testing is done using BabaSSL only since OpenSSL
+  doesn't support SMx cipher suites.
+* SM3 is disabled by default due to known issue from cryto_mb. When SM3 enabled,
+  Performance drop observed in mulithread scenario for all ciphers suites
+  due to the locks at engine_table_select in OpenSSL.
diff --git a/docs/software_requirements.md b/docs/software_requirements.md
@@ -8,9 +8,9 @@ Driver for FreeBSD. This release was validated on the following:
 
 * Operating system: CentOS\* 7.4 64-bit version & FreeBSD\* 11.4 64-bit version
 * Kernel: GNU\*/Linux\* 3.10.0-693
-* Intel&reg; Communications Chipset C62X Series Software for Linux\*, version **4.15**
+* Intel&reg; Communications Chipset C62X Series Software for Linux\*, version **4.16**
 * Intel&reg; Communications Chipset C62X Series Software for FreeBSD\*, version **3.11**
-* OpenSSL\* 1.1.1l & 3.0
+* OpenSSL\* 1.1.1m & 3.0.1
 
 ## qat_sw Requirements
 Successful operation of the Intel&reg; QAT Software acceleration requires a
@@ -31,7 +31,7 @@ This release was validated on the following:
 * Intel&reg; Crypto Multi-buffer library from the [ipp-crypto][1] release
   version **IPP Crypto 2021.4**
 * Intel&reg; Multi-Buffer crypto for IPsec Library release version **v1.0**
-* OpenSSL\* 1.1.1l & 3.0
+* OpenSSL\* 1.1.1m & 3.0.1
 
 [1]:https://github.com/intel/ipp-crypto
 [2]:https://github.com/intel/ipp-crypto/tree/develop/sources/ippcp/crypto_mb

diff --git a/e_qat.c b/e_qat.c
@@ -154,13 +154,13 @@
 const char *engine_qat_id = STR(QAT_ENGINE_ID);
 #if defined(QAT_HW) && defined(QAT_SW)
 const char *engine_qat_name =
-    "Reference implementation of QAT crypto engine(qat_hw & qat_sw) v0.6.10";
+    "Reference implementation of QAT crypto engine(qat_hw & qat_sw) v0.6.11";
 #elif QAT_HW
 const char *engine_qat_name =
-    "Reference implementation of QAT crypto engine(qat_hw) v0.6.10";
+    "Reference implementation of QAT crypto engine(qat_hw) v0.6.11";
 #else
 const char *engine_qat_name =
-    "Reference implementation of QAT crypto engine(qat_sw) v0.6.10";
+    "Reference implementation of QAT crypto engine(qat_sw) v0.6.11";
 #endif
 unsigned int engine_inited = 0;
 
@@ -388,6 +388,8 @@ static int qat_engine_destroy(ENGINE *e)
     qat_hw_prf_offload = 0;
     qat_hw_hkdf_offload = 0;
     qat_sw_ecx_offload = 0;
+    qat_sw_sm2_offload = 0;
+    qat_sw_sm3_offload = 0;
     QAT_DEBUG_LOG_CLOSE();
     ERR_unload_QAT_strings();
     return 1;

diff --git a/e_qat.txt b/e_qat.txt
@@ -358,22 +358,25 @@ QAT_R_SET_TAG_INVALID_OP:326:set tag invalid op
 QAT_R_SHA3_CTX_NULL:327:sha3 ctx null
 QAT_R_SIG_GET_R_S_FAILURE:328:sig get r s failure
 QAT_R_SIG_MALLOC_FAILURE:329:sig malloc failure
-QAT_R_SSD_MALLOC_FAILURE:330:ssd malloc failure
-QAT_R_SSD_NULL:331:ssd null
-QAT_R_START_INSTANCE_FAILURE:332:start instance failure
-QAT_R_STOP_INSTANCE_FAILURE:333:stop instance failure
-QAT_R_SW_GET_COMPUTE_KEY_PFUNC_NULL:334:sw get compute key pfunc null
-QAT_R_SW_GET_KEYGEN_PFUNC_NULL:335:sw get keygen pfunc null
-QAT_R_SW_GET_SIGN_PFUNC_NULL:336:sw get sign pfunc null
-QAT_R_SW_GET_SIGN_SETUP_PFUNC_NULL:337:sw get sign setup pfunc null
-QAT_R_SW_GET_SIGN_SIG_PFUNC_NULL:338:sw get sign sig pfunc null
-QAT_R_SW_GET_VERIFY_SIG_PFUNC_NULL:339:sw get verify sig pfunc null
-QAT_R_SW_METHOD_NULL:340:sw method null
-QAT_R_S_NULL:341:s null
-QAT_R_S_Q_COMPARE_FAILURE:342:s q compare failure
-QAT_R_UNKNOWN_PADDING:343:unknown padding
-QAT_R_UNKNOWN_PADDING_TYPE:344:unknown padding type
-QAT_R_WAKE_PAUSE_JOB_FAILURE:345:wake pause job failure
-QAT_R_X_Y_TX_TY_BN_MALLOC_FAILURE:346:x y tx ty bn malloc failure
-QAT_R_X_Y_Z_MALLOC_FAILURE:347:x y z malloc failure
-QAT_R_Z_ALLOCATE_FAILURE:348:z allocate failure
+QAT_R_SM3_FINAL_FAILURE:330:sm3 final failure
+QAT_R_SM3_INIT_FAILURE:331:sm3 init failure
+QAT_R_SM3_UPDATE_FAILURE:332:sm3 update failure
+QAT_R_SSD_MALLOC_FAILURE:333:ssd malloc failure
+QAT_R_SSD_NULL:334:ssd null
+QAT_R_START_INSTANCE_FAILURE:335:start instance failure
+QAT_R_STOP_INSTANCE_FAILURE:336:stop instance failure
+QAT_R_SW_GET_COMPUTE_KEY_PFUNC_NULL:337:sw get compute key pfunc null
+QAT_R_SW_GET_KEYGEN_PFUNC_NULL:338:sw get keygen pfunc null
+QAT_R_SW_GET_SIGN_PFUNC_NULL:339:sw get sign pfunc null
+QAT_R_SW_GET_SIGN_SETUP_PFUNC_NULL:340:sw get sign setup pfunc null
+QAT_R_SW_GET_SIGN_SIG_PFUNC_NULL:341:sw get sign sig pfunc null
+QAT_R_SW_GET_VERIFY_SIG_PFUNC_NULL:342:sw get verify sig pfunc null
+QAT_R_SW_METHOD_NULL:343:sw method null
+QAT_R_S_NULL:344:s null
+QAT_R_S_Q_COMPARE_FAILURE:345:s q compare failure
+QAT_R_UNKNOWN_PADDING:346:unknown padding
+QAT_R_UNKNOWN_PADDING_TYPE:347:unknown padding type
+QAT_R_WAKE_PAUSE_JOB_FAILURE:348:wake pause job failure
+QAT_R_X_Y_TX_TY_BN_MALLOC_FAILURE:349:x y tx ty bn malloc failure
+QAT_R_X_Y_Z_MALLOC_FAILURE:350:x y z malloc failure
+QAT_R_Z_ALLOCATE_FAILURE:351:z allocate failure
diff --git a/e_qat_err.c b/e_qat_err.c
@@ -475,6 +475,9 @@ static ERR_STRING_DATA QAT_str_reasons[] = {
     {ERR_PACK(0, 0, QAT_R_SHA3_CTX_NULL), "sha3 ctx null"},
     {ERR_PACK(0, 0, QAT_R_SIG_GET_R_S_FAILURE), "sig get r s failure"},
     {ERR_PACK(0, 0, QAT_R_SIG_MALLOC_FAILURE), "sig malloc failure"},
+    {ERR_PACK(0, 0, QAT_R_SM3_FINAL_FAILURE), "sm3 final failure"},
+    {ERR_PACK(0, 0, QAT_R_SM3_INIT_FAILURE), "sm3 init failure"},
+    {ERR_PACK(0, 0, QAT_R_SM3_UPDATE_FAILURE), "sm3 update failure"},
     {ERR_PACK(0, 0, QAT_R_SSD_MALLOC_FAILURE), "ssd malloc failure"},
     {ERR_PACK(0, 0, QAT_R_SSD_NULL), "ssd null"},
     {ERR_PACK(0, 0, QAT_R_START_INSTANCE_FAILURE), "start instance failure"},

diff --git a/e_qat_err.h b/e_qat_err.h
@@ -373,24 +373,27 @@ void ERR_QAT_error(int function, int reason, char *file, int line);
 # define QAT_R_SHA3_CTX_NULL                              327
 # define QAT_R_SIG_GET_R_S_FAILURE                        328
 # define QAT_R_SIG_MALLOC_FAILURE                         329
-# define QAT_R_SSD_MALLOC_FAILURE                         330
-# define QAT_R_SSD_NULL                                   331
-# define QAT_R_START_INSTANCE_FAILURE                     332
-# define QAT_R_STOP_INSTANCE_FAILURE                      333
-# define QAT_R_SW_GET_COMPUTE_KEY_PFUNC_NULL              334
-# define QAT_R_SW_GET_KEYGEN_PFUNC_NULL                   335
-# define QAT_R_SW_GET_SIGN_PFUNC_NULL                     336
-# define QAT_R_SW_GET_SIGN_SETUP_PFUNC_NULL               337
-# define QAT_R_SW_GET_SIGN_SIG_PFUNC_NULL                 338
-# define QAT_R_SW_GET_VERIFY_SIG_PFUNC_NULL               339
-# define QAT_R_SW_METHOD_NULL                             340
-# define QAT_R_S_NULL                                     341
-# define QAT_R_S_Q_COMPARE_FAILURE                        342
-# define QAT_R_UNKNOWN_PADDING                            343
-# define QAT_R_UNKNOWN_PADDING_TYPE                       344
-# define QAT_R_WAKE_PAUSE_JOB_FAILURE                     345
-# define QAT_R_X_Y_TX_TY_BN_MALLOC_FAILURE                346
-# define QAT_R_X_Y_Z_MALLOC_FAILURE                       347
-# define QAT_R_Z_ALLOCATE_FAILURE                         348
+# define QAT_R_SM3_FINAL_FAILURE                          330
+# define QAT_R_SM3_INIT_FAILURE                           331
+# define QAT_R_SM3_UPDATE_FAILURE                         332
+# define QAT_R_SSD_MALLOC_FAILURE                         333
+# define QAT_R_SSD_NULL                                   334
+# define QAT_R_START_INSTANCE_FAILURE                     335
+# define QAT_R_STOP_INSTANCE_FAILURE                      336
+# define QAT_R_SW_GET_COMPUTE_KEY_PFUNC_NULL              337
+# define QAT_R_SW_GET_KEYGEN_PFUNC_NULL                   338
+# define QAT_R_SW_GET_SIGN_PFUNC_NULL                     339
+# define QAT_R_SW_GET_SIGN_SETUP_PFUNC_NULL               340
+# define QAT_R_SW_GET_SIGN_SIG_PFUNC_NULL                 341
+# define QAT_R_SW_GET_VERIFY_SIG_PFUNC_NULL               342
+# define QAT_R_SW_METHOD_NULL                             343
+# define QAT_R_S_NULL                                     344
+# define QAT_R_S_Q_COMPARE_FAILURE                        345
+# define QAT_R_UNKNOWN_PADDING                            346
+# define QAT_R_UNKNOWN_PADDING_TYPE                       347
+# define QAT_R_WAKE_PAUSE_JOB_FAILURE                     348
+# define QAT_R_X_Y_TX_TY_BN_MALLOC_FAILURE                349
+# define QAT_R_X_Y_Z_MALLOC_FAILURE                       350
+# define QAT_R_Z_ALLOCATE_FAILURE                         351
 
 #endif
diff --git a/qat_evp.c b/qat_evp.c
@@ -208,17 +208,20 @@ static int pkt_threshold_table_size =
 static EC_KEY_METHOD *qat_ec_method = NULL;
 static EVP_PKEY_METHOD *_hidden_x25519_pmeth = NULL;
 static EVP_PKEY_METHOD *_hidden_x448_pmeth = NULL;
+static EVP_MD *qat_sw_sm3_meth = NULL;
 
 /* Have a store of the s/w EVP_PKEY_METHOD for software fallback purposes. */
 const EVP_PKEY_METHOD *sw_x25519_pmeth = NULL;
 const EVP_PKEY_METHOD *sw_x448_pmeth = NULL;
-EVP_MD *qat_sw_sm3_meth = NULL;
 
 const EVP_MD *qat_sw_create_sm3_meth(int nid , int key_type)
 {
 #ifdef ENABLE_QAT_SW_SM3
     int res = 1;
 
+    if (qat_sw_sm3_meth)
+        return qat_sw_sm3_meth;
+
     if ((qat_sw_sm3_meth = EVP_MD_meth_new(nid, key_type)) == NULL) {
         WARN("Failed to allocate digest methods for nid %d\n", nid);
         return NULL;
@@ -227,13 +230,14 @@ const EVP_MD *qat_sw_create_sm3_meth(int nid , int key_type)
     /* For now check using MBX_ALGO_X25519 as algo info for sm3 is not implemented */
     if (mbx_get_algo_info(MBX_ALGO_X25519)) {
         res &= EVP_MD_meth_set_result_size(qat_sw_sm3_meth, 32);
-        res &= EVP_MD_meth_set_input_blocksize(qat_sw_sm3_meth, 64);
-        res &= EVP_MD_meth_set_app_datasize(qat_sw_sm3_meth, sizeof(EVP_MD*) + 580);
-        res &= EVP_MD_meth_set_flags(qat_sw_sm3_meth, (EVP_MD_CTX_FLAG_ONESHOT|EVP_MD_CTX_FLAG_NO_INIT));
+        res &= EVP_MD_meth_set_input_blocksize(qat_sw_sm3_meth, SM3_MSG_BLOCK_SIZE);
+        res &= EVP_MD_meth_set_app_datasize(qat_sw_sm3_meth, sizeof(EVP_MD *) + sizeof(SM3_CTX_mb));
+        res &= EVP_MD_meth_set_flags(qat_sw_sm3_meth, EVP_MD_CTX_FLAG_REUSE);
         res &= EVP_MD_meth_set_init(qat_sw_sm3_meth, qat_sw_sm3_init);
         res &= EVP_MD_meth_set_update(qat_sw_sm3_meth, qat_sw_sm3_update);
         res &= EVP_MD_meth_set_final(qat_sw_sm3_meth, qat_sw_sm3_final);
         qat_sw_sm3_offload = 1;
+        DEBUG("QAT SW SM3 Registration succeeded\n");
     }
 
     if (0 == res) {
@@ -242,11 +246,12 @@ const EVP_MD *qat_sw_create_sm3_meth(int nid , int key_type)
         qat_sw_sm3_meth = NULL;
     }
 
-    DEBUG("QAT SW SM3 Registration succeeded\n");
 #endif
 
-    if (!qat_sw_sm3_offload)
-        return EVP_sm3();
+    if (!qat_sw_sm3_offload) {
+        qat_sw_sm3_meth = (EVP_MD *)EVP_sm3();
+        DEBUG("OpenSSL SW SM3\n");
+    }
 
     return qat_sw_sm3_meth;
 }
@@ -264,22 +269,23 @@ static const EVP_MD *qat_create_digest_meth(int nid , int pkeytype)
 {
     switch (nid) {
 #ifdef ENABLE_QAT_HW_SHA3
-        case NID_sha3_224:
-        case NID_sha3_256:
-        case NID_sha3_384:
-        case NID_sha3_512:
-            if (qat_hw_offload)
-                return qat_create_sha3_meth(nid , pkeytype);
+    case NID_sha3_224:
+    case NID_sha3_256:
+    case NID_sha3_384:
+    case NID_sha3_512:
+        if (qat_hw_offload)
+            return qat_create_sha3_meth(nid , pkeytype);
 #endif
 #ifdef ENABLE_QAT_SW_SM3
-        case NID_sm3:
-            return qat_sw_create_sm3_meth(nid , pkeytype);
+    case NID_sm3:
+        return qat_sw_create_sm3_meth(nid , pkeytype);
 #endif
-        default:
-            WARN("Invalid nid %d\n", nid);
-            return NULL;
+    default:
+        WARN("Invalid nid %d\n", nid);
+        return NULL;
     }
 }
+
 /******************************************************************************
  * function:
  *         qat_digest_methods(ENGINE *e,

diff --git a/qat_hw_rsa.c b/qat_hw_rsa.c
@@ -274,6 +274,16 @@ static int qat_rsa_decrypt(CpaCyRsaDecryptOpData * dec_op_data, int rsa_len,
          * will begin to poll the instance.
          */
         QAT_INC_IN_FLIGHT_REQS(num_requests_in_flight, tlv);
+        if (qat_use_signals()) {
+            if (tlv->localOpsInFlight == 1) {
+                if (qat_kill_thread(qat_timer_poll_func_thread, SIGUSR1) != 0) {
+                    WARN("qat_kill_thread error\n");
+                    QATerr(QAT_F_QAT_RSA_DECRYPT, ERR_R_INTERNAL_ERROR);
+                    QAT_DEC_IN_FLIGHT_REQS(num_requests_in_flight, tlv);
+                    return 0;
+                }
+            }
+        }
         qat_cleanup_op_done(&op_done);
         sync_mode_ret = qat_rsa_decrypt_CRT(dec_op_data, rsa_len, output_buf, fallback);
         QAT_DEC_IN_FLIGHT_REQS(num_requests_in_flight, tlv);

diff --git a/qat_prov.txt b/qat_prov.txt
@@ -246,22 +246,25 @@ QAT_R_SET_TAG_INVALID_OP:326:set tag invalid op
 QAT_R_SHA3_CTX_NULL:327:sha3 ctx null
 QAT_R_SIG_GET_R_S_FAILURE:328:sig get r s failure
 QAT_R_SIG_MALLOC_FAILURE:329:sig malloc failure
-QAT_R_SSD_MALLOC_FAILURE:330:ssd malloc failure
-QAT_R_SSD_NULL:331:ssd null
-QAT_R_START_INSTANCE_FAILURE:332:start instance failure
-QAT_R_STOP_INSTANCE_FAILURE:333:stop instance failure
-QAT_R_SW_GET_COMPUTE_KEY_PFUNC_NULL:334:sw get compute key pfunc null
-QAT_R_SW_GET_KEYGEN_PFUNC_NULL:335:sw get keygen pfunc null
-QAT_R_SW_GET_SIGN_PFUNC_NULL:336:sw get sign pfunc null
-QAT_R_SW_GET_SIGN_SETUP_PFUNC_NULL:337:sw get sign setup pfunc null
-QAT_R_SW_GET_SIGN_SIG_PFUNC_NULL:338:sw get sign sig pfunc null
-QAT_R_SW_GET_VERIFY_SIG_PFUNC_NULL:339:sw get verify sig pfunc null
-QAT_R_SW_METHOD_NULL:340:sw method null
-QAT_R_S_NULL:341:s null
-QAT_R_S_Q_COMPARE_FAILURE:342:s q compare failure
-QAT_R_UNKNOWN_PADDING:343:unknown padding
-QAT_R_UNKNOWN_PADDING_TYPE:344:unknown padding type
-QAT_R_WAKE_PAUSE_JOB_FAILURE:345:wake pause job failure
-QAT_R_X_Y_TX_TY_BN_MALLOC_FAILURE:346:x y tx ty bn malloc failure
-QAT_R_X_Y_Z_MALLOC_FAILURE:347:x y z malloc failure
-QAT_R_Z_ALLOCATE_FAILURE:348:z allocate failure
+QAT_R_SM3_FINAL_FAILURE:330:sm3 final failure
+QAT_R_SM3_INIT_FAILURE:331:sm3 init failure
+QAT_R_SM3_UPDATE_FAILURE:332:sm3 update failure
+QAT_R_SSD_MALLOC_FAILURE:333:ssd malloc failure
+QAT_R_SSD_NULL:334:ssd null
+QAT_R_START_INSTANCE_FAILURE:335:start instance failure
+QAT_R_STOP_INSTANCE_FAILURE:336:stop instance failure
+QAT_R_SW_GET_COMPUTE_KEY_PFUNC_NULL:337:sw get compute key pfunc null
+QAT_R_SW_GET_KEYGEN_PFUNC_NULL:338:sw get keygen pfunc null
+QAT_R_SW_GET_SIGN_PFUNC_NULL:339:sw get sign pfunc null
+QAT_R_SW_GET_SIGN_SETUP_PFUNC_NULL:340:sw get sign setup pfunc null
+QAT_R_SW_GET_SIGN_SIG_PFUNC_NULL:341:sw get sign sig pfunc null
+QAT_R_SW_GET_VERIFY_SIG_PFUNC_NULL:342:sw get verify sig pfunc null
+QAT_R_SW_METHOD_NULL:343:sw method null
+QAT_R_S_NULL:344:s null
+QAT_R_S_Q_COMPARE_FAILURE:345:s q compare failure
+QAT_R_UNKNOWN_PADDING:346:unknown padding
+QAT_R_UNKNOWN_PADDING_TYPE:347:unknown padding type
+QAT_R_WAKE_PAUSE_JOB_FAILURE:348:wake pause job failure
+QAT_R_X_Y_TX_TY_BN_MALLOC_FAILURE:349:x y tx ty bn malloc failure
+QAT_R_X_Y_Z_MALLOC_FAILURE:350:x y z malloc failure
+QAT_R_Z_ALLOCATE_FAILURE:351:z allocate failure
diff --git a/qat_prov_err.c b/qat_prov_err.c
@@ -336,6 +336,9 @@ static ERR_STRING_DATA QAT_str_reasons[] = {
     {ERR_PACK(0, 0, QAT_R_SHA3_CTX_NULL), "sha3 ctx null"},
     {ERR_PACK(0, 0, QAT_R_SIG_GET_R_S_FAILURE), "sig get r s failure"},
     {ERR_PACK(0, 0, QAT_R_SIG_MALLOC_FAILURE), "sig malloc failure"},
+    {ERR_PACK(0, 0, QAT_R_SM3_FINAL_FAILURE), "sm3 final failure"},
+    {ERR_PACK(0, 0, QAT_R_SM3_INIT_FAILURE), "sm3 init failure"},
+    {ERR_PACK(0, 0, QAT_R_SM3_UPDATE_FAILURE), "sm3 update failure"},
     {ERR_PACK(0, 0, QAT_R_SSD_MALLOC_FAILURE), "ssd malloc failure"},
     {ERR_PACK(0, 0, QAT_R_SSD_NULL), "ssd null"},
     {ERR_PACK(0, 0, QAT_R_START_INSTANCE_FAILURE), "start instance failure"},