Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Squash to "selftests: mptcp: add evts_get_info helper"
Fixed info and style issues reported by ShellCheck: In tools/testing/selftests/net/mptcp/mptcp_lib.sh line 213: grep "${2}" | sed -n 's/.*\('${1}':\)\([0-9a-f:.]*\).*$/\2/p;q' ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: grep "${2}" | sed -n 's/.*\('"${1}"':\)\([0-9a-f:.]*\).*$/\2/p;q' In tools/testing/selftests/net/mptcp/mptcp_lib.sh line 218: cat "${2}" | mptcp_lib_get_info_value "${1}" "^type:${3:-1}," ^----^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead. The first one is just to be on the safe side and the second one is just a bit better but still, there were the only two issues reported by ShellCheck: better to fix them to easily spot important issues. Signed-off-by: Matthieu Baerts <[email protected]>
- Loading branch information