update nonce via rpc before producing a new sidechain block #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenzi
added
A0-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hopefully this will fix #1639
reasoning:
Now that enclave extrinsics are mortal, it can happen that any extrinsic is purged from the tx pool without being executed. Previously, we initialized the nonce at startup and then kept track of it within our enclave only. This will break as soon as one mortality hits because nonces will leave a gap
With this PR we re-sync the nonce before attempting to execute a new block of TOPs using the node rpc function
system_accountNextIndexwhich takes into account the pending extrinsics in the pool. As all extrinsics can only be signed by our local enclave and all are sent to our own local node, the local node always knows the correct next nonce. q.e.d.