Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

add operator-sdk version check to makefile #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

philbrookes
Copy link
Member

No description provided.

@philbrookes philbrookes requested a review from hubeadmin April 8, 2021 11:02

.PHONY: code/run
code/run:
@operator-sdk up local --namespace=${NAMESPACE}
@$(OPERATOR_SDK) up local --namespace=${NAMESPACE}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this recipe is broken, should be something along the lines of @$(OPERATOR_SDK) run --local --namespace=${NAMESPACE} for <0.15.2

Copy link
Contributor

@hubeadmin hubeadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that one comment (not that big of a deal since AMO is rarely run locally, so we can ignore it for now).

Other than that, the manifests/k8s generate without a problem

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: HubertStefanski
To complete the pull request process, please assign pb82 after the PR has been reviewed.
You can assign the PR to them by writing /assign @pb82 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hubeadmin
Copy link
Contributor

@pb82 @david-martin @grdryn , If you'd like to take a look and approve?

@openshift-ci
Copy link

openshift-ci bot commented May 19, 2021

@philbrookes: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants