Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAC 1.0 compatibility, release 0.3.0 #61

Merged
merged 24 commits into from
Oct 16, 2020
Merged

Conversation

scottyhq
Copy link
Collaborator

Addresses #57

Currently hitting ValueError: Can't clean for JSON: for

    catalog = catalog['hurricane-harvey']['hurricane-harvey-0831']
    for id, entry in catalog.items():
        display(entry)

#31

cc @jhamman - i'm wondering if we can directly render one of the notebooks under examples/ in the docs instead of a separate tutorial.rst

@scottyhq
Copy link
Collaborator Author

just bypassing #31 for now and instead modifying the tutorial.rst code blocks to clarify usage. @jhamman - i'd like to get a 0.3 version out, any other must-haves before doing that?

@jhamman
Copy link
Collaborator

jhamman commented Oct 1, 2020

@scottyhq - this looks good. Can you rebase / merge after #63 and then I'll take a final pass tomorrow. Happy to make a release once this gets merged!

@scottyhq
Copy link
Collaborator Author

scottyhq commented Oct 1, 2020

Some failing tests for intake upstream:

item = StacItem(stac_item_obj)
list_of_bands = ['B1', 'B8']
B1_da = item.B1.to_dask()

url = 'https://landsat-pds.s3.amazonaws.com/c1/L8/152/038/LC08_L1TP_152038_20200611_20200611_01_RT/LC08_L1TP_152038_20200611_20200611_01_RT_B1.TIF'
169
mode = 'rb', storage_options = {}, of = <List of 1 OpenFile instances>
E           ValueError: open_local can only be used on a filesystem which has attribute local_file=True

Full log:
https://github.com/intake/intake-stac/pull/61/checks?check_run_id=1194455402

@martindurant @jhamman -not sure why the URLs are passed to open_local?..

Could also fix in a subsequent PR. I think this is ready to merge and release.

@martindurant
Copy link
Member

This is probably due to the release of intake-xarray; please forward or reference this issue there. I think it probably has to do with the distinction between file-based and URL-based open functions.

@scottyhq
Copy link
Collaborator Author

scottyhq commented Oct 2, 2020

@jhamman - since tests pass with intake-xarray 0.3.1, should we just pin to that version and release?

@jhamman
Copy link
Collaborator

jhamman commented Oct 2, 2020

@jhamman - since tests pass with intake-xarray 0.3.1, should we just pin to that version and release?

Perhaps it would be best to if we just xfailed this test for intake-xarray > 0.3.1? Hopefully upstream is fixed before we release again.

@scottyhq scottyhq changed the title [WIP] Tutorial and Tests for STAC 1.0 STAC 1.0 compatibility, release 0.3.0 Oct 15, 2020
@scottyhq
Copy link
Collaborator Author

finally! read-the-docs woes sorted. python3.9 environment failing to solve with conda, but i'm going to squash and merge this and release and hope that new dependency versions on conda-forge will be sorted soon.

@scottyhq scottyhq merged commit c1a65ce into intake:master Oct 16, 2020
@scottyhq scottyhq deleted the test1.0 branch November 24, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants