Fix/updater #506
Fix/updater #506
Conversation
.gitignore
Outdated
iblrig/__init__.py
Outdated
| @@ -1,8 +1,7 @@ | |||
| from pathlib import Path | |||
| from setuptools_scm import get_version | |||
There was a problem hiding this comment.
Is there an alternative to a new package? In general we're very careful about adding packages that are not part of the standard library or large reputable open source packages.
In this case to get the version number, I would look into alternatives.
There was a problem hiding this comment.
This one is a bit more specific, as it gets the version numbers from the local .git directory. Alternative would be to go back to hardcoding the version numbers - which wouldn't be a big deal either.
There was a problem hiding this comment.
We would, however, lose support for per-commit versions (e.g., "8.9.3.post3"), but these could probably also be possible with a bit of git magic
There was a problem hiding this comment.
git describe should do the job - I'll look into it
No description provided.