New Quiz LTI labeling

[rh12]

refs: MBL-17960
affects: Student, Teacher, Parent
release note: none

What's new

New Quizes should look like quizes, see ticket for details.
Also updated at some additional places:

• Modules screen
• Assignments screen
• Grades screen
• ToDo screen
• People Details screen
• PARENT app: Grades tab
• Assignment Details screen
• Submission Details screen (+ Comments sheet)
• Quizzes screen (not displaying untrue "0 Questions" for QuizLTIs anymore)

What's not changed

• Notifications screen
  • not updated, because users/self/activity_stream doesn't provide details
  • we could check via html_url which contains assignmentID, see ActivityStreamViewController
  • not sure it's worth it
• Calendar Events list
  • not updated, because planner/items doesn't provide details
  • we could check plannable_id when plannable_type is assignment, see Plannable.iconImage
  • not sure it's worth it
• Did not add nice to have panda

Test plan

• See ticket and above changed / not changed list.
• Test both Teacher and Student apps, they use different screens for similar things.
• Also smoke test for other type of assignments.

TODO:

• screenshots

--- edit or delete this section ---

Screenshots

Before	After

Checklist

• Follow-up e2e test ticket created
• A11y checked
• Tested on phone
• Tested on tablet
• Tested in dark mode
• Tested in light mode
• Approve from product

[inst-danger]

Parent Build QR Code:

[inst-danger]

Teacher Build QR Code:

[inst-danger]

Student Build QR Code:

[inst-danger]

	Warnings
⚠️	This pull request will not generate a release note.
⚠️	One or more files are below the minimum test coverage 50%

Affected Apps: Student, Teacher, Parent

MBL-17960

Coverage	New %	Master %	Delta
Canvas iOS	91.24%	91.22%	0.02%
Core/Core/Extensions/CGSizeExtensions.swift	0%	0%	0%
Core/Core/Search/Model/SearchSupportButtonModel.swift	0%	0%	0%
Core/Core/Courses/SmartSearch/View/CourseSmartSearchViewsProvider.swift	13.64%	13.64%	0%
Core/Core/Courses/SmartSearch/Model/CourseSmartSearchViewAttributes.swift	30.77%	30.77%	0%
Core/Core/Store/FetchedCollection.swift	48.72%	48.72%	0%

Generated by 🚫 dangerJS against 66eefdc

[suhaibabsi-inst]

Thanks @rh12 !

Code +1

With minor notes to consider.

[suhaibabsi-inst]

Tested on iPhone & iPad iOS 18, I was able to see the new labeling reflected as described in the PR description. Beside button is showing the correct label on all details screens of Quiz.

One issue through, is that questions count label doesn't show on Assignments screen. And it shows count 0 for new quizzes on Quizzes screen.

[rh12]

@suhaibabsi-inst

One issue through, is that questions count label doesn't show on Assignments screen. And it shows count 0 for new quizzes on Quizzes screen.

It is not displayed for Classic Quizzes either, so I would consider it a separate feature.
It seems to me the PR about Assignment List doesn't contain this either.
To be honest I'm not sure that this is something we want there, since it's also not listed on the Grades screen as well, which is a kind of "inspiration" for the new Assigmnets screen.
Feel free to bring it up as an improvement though, and discuss with UX/Product.

[suhaibabsi-inst]

@rh12

I got confused with what's shown on the Figma file. If time permits, let's fix the count number issue on Quizzes screen. So, to match with what we have for old quizzes.

Approving so not to block the merge.

[rh12]

@suhaibabsi-inst

If time permits, let's fix the count number issue on Quizzes screen. So, to match with what we have for old quizzes.

Sorry, I overlooked this one in your previous comment. You're right, zero is not good here.
It turns out backend doesn't send a question_count for QuizLTIs, it's also not visible on the web.
But the web hides the Question count text altogether in this case, so I did the same.