Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MBL-17673][All] Event reminder #2656

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

[MBL-17673][All] Event reminder #2656

wants to merge 27 commits into from

Conversation

domonkosadam
Copy link
Contributor

@domonkosadam domonkosadam commented Nov 28, 2024 •
edited
Loading

Test plan: Set reminders for calendar Events and Todos. As regression check, Assignment reminders can be checked as well.

refs: MBL-17673
affects: Student, Teacher
release note: Now reminders can be set for calendar events and todos .

Screenshots

BeforeAfter

Checklist

  • Run E2E test suite
  • Tested in dark mode
  • Tested in light mode

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@hermannakos hermannakos self-requested a review November 28, 2024 11:26
@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

hermannakos
hermannakos approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@hermannakos hermannakos left a comment •
edited by domonkosadam
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

  • I think it would be more intuitive (at least that's how I tried to use it) if the whole row would be clickable not just the + button.

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

kristofnemere
kristofnemere requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@kristofnemere kristofnemere left a comment •
edited by domonkosadam
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When loggin in again, the alarms should be scheduled again. See: com.instructure.pandautils.features.reminder.AlarmScheduler#scheduleAllAlarmsForCurrentUser

  • Parent app should ask for notification permission. See: com.instructure.student.activity.NavigationActivity#requestNotificationsPermission

...in/java/com/instructure/teacher/features/reminder/TeacherAlarmReceiverNotificationHandler.kt Show resolved Hide resolved
libs/pandautils/src/main/java/com/instructure/pandautils/utils/PlannerItemExtensions.kt Outdated Show resolved Hide resolved
@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Student Install Page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristofnemere kristofnemere kristofnemere requested changes

@hermannakos hermannakos hermannakos approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@domonkosadam @inst-danger @hermannakos @kristofnemere