Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test,readme,utils): update config of start operator #46

Merged
merged 1 commit into from
Nov 10, 2023
Merged

chore(test,readme,utils): update config of start operator #46

merged 1 commit into from
Nov 10, 2023

Conversation

donch1989
Copy link
Member

Because

  • the config format of start operator has been changed

This commit

  • update config of start operator

@donch1989 donch1989 requested a review from heiruwu as a code owner November 10, 2023 07:33
@donch1989 donch1989 marked this pull request as draft November 10, 2023 07:34
@donch1989 donch1989 force-pushed the huitang/update_start_operator_config branch from bf5b295 to d5ca69b Compare November 10, 2023 07:39
@codecov Codecov
Copy link

codecov bot commented Nov 10, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d83526) 53.52% compared to head (ef89e6c) 53.52%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   53.52%   53.52%           
=======================================
  Files          23       23           
  Lines         880      880           
  Branches      176      176           
=======================================
  Hits          471      471           
  Misses        390      390           
  Partials       19       19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donch1989 donch1989 force-pushed the huitang/update_start_operator_config branch from d5ca69b to ef89e6c Compare November 10, 2023 07:46
@donch1989 donch1989 marked this pull request as ready for review November 10, 2023 07:50
@heiruwu heiruwu merged commit 2ad1bfe into main Nov 10, 2023
10 checks passed
@heiruwu heiruwu deleted the huitang/update_start_operator_config branch November 10, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heiruwu heiruwu heiruwu approved these changes

Assignees
No one assigned
Labels
instill core
Projects
No open projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donch1989 @heiruwu @droplet-bot