Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add Owner message for embedding user and organization information #273

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

donch1989
Copy link
Member

@donch1989 donch1989 commented Feb 22, 2024

Because:

  • Originally, we used owner_name and owner (structpb) to embed owner information for Console. However, owner is a structpb, and it is not well-formatted. Since we already have dedicated messages for User and Organization, we should utilize these messages.

This commit:

  • Adds a new Owner message to wrap the User and Organization messages.
  • Removes owner in resource response.
  • Marks owner_name in resource response as deprecated. Once the frontend removes it, we'll remove it as well.

@donch1989 donch1989 marked this pull request as ready for review February 22, 2024 10:04
@donch1989 donch1989 marked this pull request as draft February 22, 2024 10:16
@donch1989 donch1989 marked this pull request as ready for review February 22, 2024 13:30
@donch1989 donch1989 merged commit 3ec60b8 into main Feb 22, 2024
3 checks passed
@donch1989 donch1989 deleted the huitang/ins-3664 branch February 22, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 👋 Done
Development

Successfully merging this pull request may close these issues.

3 participants