Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(model): fix type inconsistency of field ExtraParamObject #240

Merged
merged 9 commits into from
Dec 12, 2023
Merged

fix(model): fix type inconsistency of field ExtraParamObject #240

merged 9 commits into from
Dec 12, 2023

Conversation

tonywang10101
Copy link
Contributor

Because

  • The ExtraParamObject field is present as both a repeated and an optional type

This commit

  • Transfer all items to the 'repeated' section to ensure consistency.

@linear Linear
Copy link

linear bot commented Dec 12, 2023

INS-2574 Make AI tasks consistent

donch1989
donch1989 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@donch1989 donch1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonywang10101 tonywang10101 merged commit bf92376 into main Dec 12, 2023
3 checks passed
@tonywang10101 tonywang10101 deleted the INS-2574 branch December 12, 2023 09:10
@droplet-bot droplet-bot mentioned this pull request Dec 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 donch1989 approved these changes

@heiruwu heiruwu Awaiting requested review from heiruwu heiruwu is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonywang10101 @donch1989