Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(usage): add owner and user type in resource data #232

Merged
merged 1 commit into from
Dec 6, 2023
Merged

chore(usage): add owner and user type in resource data #232

merged 1 commit into from
Dec 6, 2023

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Dec 6, 2023

Because

  • differentiate orgs and users type trigger data

This commit

  • add type for user and owner for each resource

@linear Linear
Copy link

linear bot commented Dec 6, 2023

INS-2825 adopt ownerType usage/metric data collection in protobuf

donch1989
donch1989 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@donch1989 donch1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heiruwu heiruwu merged commit 857665d into main Dec 6, 2023
3 checks passed
@heiruwu heiruwu deleted the INS-2825 branch December 6, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 donch1989 approved these changes

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heiruwu @donch1989