Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(model): add namespace for model api endpoints #199

Merged
merged 2 commits into from
Aug 28, 2023
Merged

chore(model): add namespace for model api endpoints #199

merged 2 commits into from
Aug 28, 2023

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Aug 27, 2023

Because

  • We would like to make the resources be public or shared to other
    users. The current structure can not support it since the api endpoint
    was designed for the users' own resources.

This commit

  • add namespace for model api endpoints

@linear
Copy link

linear bot commented Aug 27, 2023

INS-1622 adopt namespace in model protobuf

@heiruwu heiruwu marked this pull request as ready for review August 27, 2023 15:02
@heiruwu heiruwu force-pushed the heiru/ins-1622-adopt-namespace-in-model-protobuf branch from a283e04 to ecd3803 Compare August 27, 2023 18:17
@heiruwu heiruwu force-pushed the heiru/ins-1622-adopt-namespace-in-model-protobuf branch from ecd3803 to 355d29d Compare August 27, 2023 19:01
donch1989
donch1989 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@donch1989 donch1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donch1989 donch1989 merged commit 788a12b into main Aug 28, 2023
@donch1989 donch1989 deleted the heiru/ins-1622-adopt-namespace-in-model-protobuf branch August 28, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 donch1989 approved these changes

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heiruwu @donch1989