Skip to content

Commit

Permalink
feat(vdp): support sorting pipelines under a namespace (#334)
Browse files Browse the repository at this point in the history
Because

- We should support sorting pipelines under a namespace as well.

This commit

- Supports sorting pipelines under a namespace

---------

Co-authored-by: droplet-bot <[email protected]>
  • Loading branch information
donch1989 and droplet-bot authored May 15, 2024
1 parent ccfa000 commit 8845d5e
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 2 deletions.
18 changes: 17 additions & 1 deletion openapiv2/vdp/service.swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ paths:
- VISIBILITY_PRIVATE
- VISIBILITY_PUBLIC
- name: order_by
description: Order by field.
description: |-
Order by field, with options for ordering by `id` or `create_time`.
Format: `order_by=id ASC` or `order_by=create_time DESC`.
in: query
required: false
type: string
Expand Down Expand Up @@ -732,6 +734,13 @@ paths:
in: query
required: false
type: boolean
- name: order_by
description: |-
Order by field, with options for ordering by `id` or `create_time`.
Format: `order_by=id ASC` or `order_by=create_time DESC`.
in: query
required: false
type: string
tags:
- Release
post:
Expand Down Expand Up @@ -1187,6 +1196,13 @@ paths:
enum:
- VISIBILITY_PRIVATE
- VISIBILITY_PUBLIC
- name: order_by
description: |-
Order by field, with options for ordering by `id` or `create_time`.
Format: `order_by=id ASC` or `order_by=create_time DESC`.
in: query
required: false
type: string
tags:
- Pipeline
post:
Expand Down
9 changes: 8 additions & 1 deletion vdp/pipeline/v1beta/pipeline.proto
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,8 @@ message ListPipelinesRequest {
optional bool show_deleted = 5 [(google.api.field_behavior) = OPTIONAL];
// Limit results to pipelines with the specified visibility.
optional Pipeline.Visibility visibility = 6 [(google.api.field_behavior) = OPTIONAL];
// Order by field.
// Order by field, with options for ordering by `id` or `create_time`.
// Format: `order_by=id ASC` or `order_by=create_time DESC`.
optional string order_by = 7 [(google.api.field_behavior) = OPTIONAL];
}

Expand Down Expand Up @@ -732,6 +733,9 @@ message ListUserPipelineReleasesRequest {
];
// Include soft-deleted pipelines in the result.
optional bool show_deleted = 6 [(google.api.field_behavior) = OPTIONAL];
// Order by field, with options for ordering by `id` or `create_time`.
// Format: `order_by=id ASC` or `order_by=create_time DESC`.
optional string order_by = 7 [(google.api.field_behavior) = OPTIONAL];
}

// ListUserPipelineReleasesResponse contains a list of pipeline releases.
Expand Down Expand Up @@ -955,6 +959,9 @@ message ListOrganizationPipelinesRequest {
optional bool show_deleted = 6 [(google.api.field_behavior) = OPTIONAL];
// Limit results to pipelines with the specified visibility.
optional Pipeline.Visibility visibility = 7 [(google.api.field_behavior) = OPTIONAL];
// Order by field, with options for ordering by `id` or `create_time`.
// Format: `order_by=id ASC` or `order_by=create_time DESC`.
optional string order_by = 8 [(google.api.field_behavior) = OPTIONAL];
}

// ListOrganizationPipelinesResponse contains a list of pipelines.
Expand Down

0 comments on commit 8845d5e

Please sign in to comment.