-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(model): update chat_history schema to align with OpenAI message field #481
Conversation
…with the OpenAI Interface Specifications
…Standards (#479) Because ... - This update is necessitated by the need to align our current text-generation-task schema more closely with OpenAI's task structure. This commit .. 1. **Enhancement of TASK_TEXT_GENERATION**: Following our discussion in [INS-2982](https://linear.app/instill-ai/issue/INS-2982/harmonizing-the-text-generation-tasks-protocol-buffer-with-the-openai), we have introduced three new fields to the `TASK_TEXT_GENERATION` protocol buffer: - An optional `system_message` string. - An optional `chat_history` field, now mirroring the type used in `conversation`. - An optional `image_url` string, which is a base64 encoded string including batch dimension. 2. **Improved `extra_param` Support**: To offer enhanced functionality for the `extra_param`, we have implemented the suggestions in [INS-2954](https://linear.app/instill-ai/issue/INS-2954/improve-param-value-filed-type). 3. **Protobuf Structure Update**: In line with the recent [commit](instill-ai/protobufs@61c3ca8) to our protobuf repository, we have migrated the `model owner` and `org` fields to a new unified `owner` field, ensuring consistency across our models. Related changes - [protobuf PR](instill-ai/protobufs#243). After this PR merged, we needs to update go mod here - SDK (WIP)
Because - We need to standardize the naming convention of customized headers This commit - replace `Jwt-Sub` with `Instill-User-Uid`
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
========================================
- Coverage 0.91% 0.89% -0.03%
========================================
Files 10 10
Lines 6215 6385 +170
========================================
Hits 57 57
- Misses 6150 6320 +170
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: tony.wang.10101 <[email protected]>
Signed-off-by: tony.wang.10101 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Because ...
This commit ...
Enhancement of TASK_TEXT_GENERATION: Following our discussion in INS-2982, we have introduced three new fields to the
TASK_TEXT_GENERATION
protocol buffer:system_message
string.chat_history
field, now mirroring the type used inconversation
.image_url
string, which is a base64 encoded string including batch dimension.Improved
extra_param
Support: To offer enhanced functionality for theextra_param
, we have implemented the suggestions in INS-2954.This PR is based on the basis PR-243 and made some modifications to the
chat_history
field to align with the OpenAI message fieldBased on information provided by Xiaofei, following are patterns of OpenAI
message
field:And inside content:
If it is a text
if it is an image
reference to this slack thread to get more informations