Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up unused console log #1610

Merged
merged 1 commit into from
Nov 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ export type DownloadableFilesFieldProps = {
export const DownloadableFilesField = (props: DownloadableFilesFieldProps) => {
const { title, hideField, files } = props;

console.log("files", files);

return (
<FieldRoot title={title} fieldKey={`${title}-field`}>
{!hideField ? (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ export const FileAndStringUploadField = ({
disabled={disabled}
onChange={async (e) => {
const file = e.target.files?.[0];
console.log("file", file);
if (file) {
field.onChange(file);
setFileName(file.name);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@
accessorKey: "pipelineId",
header: () => <div className="text-left">Pipeline ID</div>,
cell: ({ row }) => {
console.log(row.original);
return (
<div className="font-normal text-semantic-bg-secondary-secondary truncate">
<Link
Expand Down Expand Up @@ -237,7 +236,7 @@
];

return baseColumns;
}, [orderBy, targetNamespace?.id]);

Check warning on line 239 in packages/toolkit/src/view/dashboard/cost/pipeline/DashboardListPipeline.tsx

View workflow job for this annotation

GitHub Actions / unit-test

React Hook React.useMemo has an unnecessary dependency: 'targetNamespace.id'. Either exclude it or remove the dependency array

if (pipelineRuns.isSuccess && pipelineRuns.data.pipelineRuns.length === 0) {
return (
Expand Down
10 changes: 0 additions & 10 deletions packages/toolkit/src/view/recipe-editor/RecipeEditorView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,6 @@ export const RecipeEditorView = () => {
(Object.keys(recipe ?? {}).length === 1 &&
Object.keys(recipe ?? {})[0] === "version");

console.log("recipeIsEmpty", recipeIsEmpty, Object.keys(recipe ?? {}));

const previewView =
recipe && !recipeIsEmpty ? (
<ErrorBoundary fallbackRender={() => <PreviewEmptyView />}>
Expand Down Expand Up @@ -250,14 +248,6 @@ export const RecipeEditorView = () => {
closeable: false,
};

console.log(
"pipelineIsNew",
recipe,
pipelineIsNew,
removeInitialzedViews,
newPreviewView,
);

return {
topRight: {
views: pipelineIsNew
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -409,8 +409,6 @@ export const ComponentCmdo = () => {
// set default task
const defaultTask = definition.tasks[0];

console.log("defaultTask", defaultTask);

if (!defaultTask) {
return;
}
Expand Down Expand Up @@ -485,8 +483,6 @@ export const ComponentCmdo = () => {
} else {
const defaultDefinition = eventDefinitions[0];

console.log("defaultDefinition", defaultDefinition);

if (!defaultDefinition || !defaultDefinition.spec.eventSpecifications) {
return;
}
Expand All @@ -497,8 +493,6 @@ export const ComponentCmdo = () => {
defaultDefinition.spec.eventSpecifications,
)[0];

console.log("defaultTask", defaultTask);

if (!defaultTask) {
return;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ const selector = (store: InstillStore) => ({
});

export const RunOnEventNode = ({ id, data }: NodeProps<RunOnEventNodeData>) => {
console.log("data", data);

const reactflowEdges = useEdges();
const hasTargetEdges = React.useMemo(() => {
return reactflowEdges.some(
Expand Down Expand Up @@ -110,8 +108,6 @@ export const RunOnEventNode = ({ id, data }: NodeProps<RunOnEventNodeData>) => {
}));
}, [id, updateSelectedComponentId]);

console.log("data", data);

return featureFlagWebhookEnabled ? (
<NodeBase
id={id}
Expand Down
2 changes: 0 additions & 2 deletions packages/toolkit/src/view/recipe-editor/input/Input.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -460,8 +460,6 @@ export const Input = ({
}
}

console.log("newComponent", newComponent);

updateTriggerPipelineStreamMap((prev) => {
// We need to merge the old component with the new component
const mergedComponent: GeneralRecord = prev?.component ?? {};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ export function createNodesFromRunOnEvent(
componentMetadata = metadata.component[id] ?? null;
}

console.log("e", e);

nodes.push({
id: `on-${id}`,
type: "runOnEventNode",
Expand Down
Loading