Skip to content

Commit

Permalink
feat(dashboard): rename pipeline/model triggers to runs (#1597)
Browse files Browse the repository at this point in the history
Because

- rename pipeline/model triggers to runs

This commit

- rename pipeline/model triggers to runs
  • Loading branch information
EiffelFly authored Nov 14, 2024
1 parent ae051d1 commit d32ce87
Show file tree
Hide file tree
Showing 10 changed files with 29 additions and 29 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ export const Default = () => {
column.toggleSorting(column.getIsSorted() === "asc")
}
>
<span className="min-w-[130px]">Completed Triggers</span>
<span className="min-w-[130px]">Completed Runs</span>
{getIcon(column.getIsSorted())}
</Button>
</div>
Expand Down Expand Up @@ -308,7 +308,7 @@ export const NoDataFound = () => {
column.toggleSorting(column.getIsSorted() === "asc")
}
>
<span className="min-w-[130px]">Completed Triggers</span>
<span className="min-w-[130px]">Completed Runs</span>
{getIcon(column.getIsSorted())}
</Button>
</div>
Expand Down
4 changes: 2 additions & 2 deletions packages/design-system/src/new-ui/Table/Table.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ export const Regular: Story = {
<Table.Head className="w-auto text-left">Pipeline ID</Table.Head>
<Table.Head className="w-[100px] text-center">Status</Table.Head>
<Table.Head className="w-[200px] text-center">
Completed Triggers
Completed Runs
</Table.Head>
<Table.Head className="w-[150px] text-center">
Errored Triggers
Errored Runs
</Table.Head>
</Table.Row>
</Table.Header>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ export const DashboardPipelineListPageMainView = (
return (
<div className="flex flex-col">
<h2 className="mb-10 w-full text-3xl font-semibold leading-[38px] text-semantic-fg-primary">
Pipeline Triggers
Pipeline Runs
</h2>

{/* Status */}
Expand Down
10 changes: 5 additions & 5 deletions packages/toolkit/src/view/dashboard/DashboardPipelinesTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export const DashboardPipelinesTable = (
column.toggleSorting(column.getIsSorted() === "asc")
}
>
<span className="min-w-[130px]">Completed Triggers</span>
<span className="min-w-[130px]">Completed Runs</span>
<SortIcon type={column.getIsSorted()} />
</Button>
</div>
Expand All @@ -83,7 +83,7 @@ export const DashboardPipelinesTable = (
size="sm"
onClick={() => column.toggleSorting(column.getIsSorted() === "asc")}
>
<span className="min-w-[110px]">Errored Triggers</span>
<span className="min-w-[110px]">Errored Runs</span>
<SortIcon type={column.getIsSorted()} />
</Button>
</div>
Expand All @@ -109,7 +109,7 @@ export const DashboardPipelinesTable = (
isLoading={isLoading}
loadingRows={6}
primaryText="Pipelines"
secondaryText="Select pipelines from the table below to view the number of pipeline triggers"
secondaryText="Select pipelines from the table below to view the number of pipeline runs"
>
<TableError marginBottom="!border-0" />
</DataTable>
Expand All @@ -127,7 +127,7 @@ export const DashboardPipelinesTable = (
isLoading={isLoading}
loadingRows={6}
primaryText="Pipelines"
secondaryText="Select pipelines from the table below to view the number of pipeline triggers"
secondaryText="Select pipelines from the table below to view the number of pipeline runs"
>
<PipelineTablePlaceholder
enableCreateButton={false}
Expand All @@ -147,7 +147,7 @@ export const DashboardPipelinesTable = (
isLoading={isLoading}
loadingRows={6}
primaryText="Pipelines"
secondaryText="Select pipelines from the table below to view the number of pipeline triggers"
secondaryText="Select pipelines from the table below to view the number of pipeline runs"
/>
);
};
8 changes: 4 additions & 4 deletions packages/toolkit/src/view/dashboard/PipelineTriggersTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export const PipelineTriggersTable = (props: PipelineTriggersTableProps) => {
isLoading={isLoading}
loadingRows={6}
primaryText={null}
secondaryText="Pipeline triggers"
secondaryText="Pipeline runs"
>
<TableError marginBottom="!border-0" />
</DataTable>
Expand All @@ -121,7 +121,7 @@ export const PipelineTriggersTable = (props: PipelineTriggersTableProps) => {
isLoading={isLoading}
loadingRows={6}
primaryText={null}
secondaryText="Pipeline triggers"
secondaryText="Pipeline runs"
>
<TriggersTablePlaceholder
enableCreateButton={false}
Expand All @@ -136,12 +136,12 @@ export const PipelineTriggersTable = (props: PipelineTriggersTableProps) => {
columns={columns}
data={pipelineTriggers}
pageSize={6}
searchPlaceholder={"Search Triggers"}
searchPlaceholder={"Search runs"}
searchKey={null}
isLoading={isLoading}
loadingRows={6}
primaryText={null}
secondaryText="Pipeline triggers"
secondaryText="Pipeline runs"
/>
);
};
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ export const TriggersTablePlaceholder = (
return (
<TablePlaceholderBase
placeholderItems={placeholderItems}
placeholderTitle="No Triggers"
placeholderTitle="No Runs"
createButtonLink="/pipelines/create"
createButtonTitle="Set up your first pipeline"
marginBottom={marginBottom}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,15 @@ const ModelTriggersSummaryCard = (props: {

switch (statusType) {
case "STATUS_COMPLETED": {
summaryName = "Completed Triggers";
summaryName = "Completed Runs";
break;
}
case "STATUS_ERRORED": {
summaryName = "Error Triggers";
summaryName = "Error Runs";
break;
}
default: {
summaryName = "Unspecific Triggers";
summaryName = "Unspecific Runs";
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export const ModelsTriggerCountsLineChart = ({
<div class="Date product-body-text-4-medium" style="color: var(--semantic-fg-disabled); font-size: 12px; line-height: 16px; word-wrap: break-word">${triggerTime}</div>
<div style="display: flex; align-items: center; white-space: nowrap;">
<span class="PipelineId product-body-text-3-regular" style="color: var(--semantic-fg-secondary); font-size: 14px; line-height: 20px;">
All model triggers&nbsp;
All model runs&nbsp;
</span>
<span class="Number product-body-text-3-semibold" style="color: var(--semantic-fg-primary); font-size: 14px; line-height: 20px;">${computeTimeDuration}</span>
</div>
Expand Down Expand Up @@ -143,7 +143,7 @@ export const ModelsTriggerCountsLineChart = ({
},
series: [
{
name: "Model Triggers",
name: "Model Runs",
type: "line",
smooth: false,
data: yAxis,
Expand Down Expand Up @@ -180,7 +180,7 @@ export const ModelsTriggerCountsLineChart = ({
<div className="inline-flex items-center justify-between gap-2.5 self-stretch pt-8 px-8">
<div className="flex items-center justify-start gap-2.5">
<div className="text-semantic-fg-primary product-headings-heading-2">
Number of model triggers
Number of model runs
</div>
<Tooltip.Provider>
<Tooltip.Root>
Expand All @@ -198,11 +198,11 @@ export const ModelsTriggerCountsLineChart = ({
<div className="inline-flex w-80 flex-col items-start justify-start rounded-sm bg-semantic-bg-primary p-3">
<div className="flex flex-col items-start justify-start gap-1 self-stretch">
<div className="self-stretch text-semantic-fg-primary product-body-text-4-semibold">
Number of triggers
Number of runs
</div>
<div className="self-stretch text-semantic-fg-secondary product-body-text-4-medium">
Select any pipeline from the table below to view the
number of model triggers within the last{" "}
number of model runs within the last{" "}
{selectedTimeOption.label}
</div>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export const PipelineTriggerCountsLineChart = ({
<div class="Date product-body-text-4-medium" style="color: var(--semantic-fg-disabled); font-size: 12px; line-height: 16px; word-wrap: break-word">${triggerTime}</div>
<div style="display: flex; align-items: center; white-space: nowrap;">
<span class="PipelineId product-body-text-3-regular" style="color: var(--semantic-fg-secondary); font-size: 14px; line-height: 20px;">
All pipeline triggers&nbsp;
All pipeline runs&nbsp;
</span>
<span class="Number product-body-text-3-semibold" style="color: var(--semantic-fg-primary); font-size: 14px; line-height: 20px;">${computeTimeDuration}</span>
</div>
Expand Down Expand Up @@ -185,7 +185,7 @@ export const PipelineTriggerCountsLineChart = ({
<div className="inline-flex items-center justify-between gap-2.5 self-stretch pt-8 px-8">
<div className="flex items-center justify-start gap-2.5">
<div className="text-semantic-fg-primary product-headings-heading-2">
Number of pipeline triggers
Number of pipeline runs
</div>
<Tooltip.Provider>
<Tooltip.Root>
Expand All @@ -203,7 +203,7 @@ export const PipelineTriggerCountsLineChart = ({
<div className="inline-flex w-80 flex-col items-start justify-start rounded-sm bg-semantic-bg-primary p-3">
<div className="flex flex-col items-start justify-start gap-1 self-stretch">
<div className="self-stretch text-semantic-fg-primary product-body-text-4-semibold">
Number of pipeline triggers
Number of pipeline runs
</div>
</div>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,15 @@ const PipelineTriggersSummaryCard = (props: {

switch (statusType) {
case "STATUS_COMPLETED": {
summaryName = "Completed Triggers";
summaryName = "Completed Runs";
break;
}
case "STATUS_ERRORED": {
summaryName = "Error Triggers";
summaryName = "Error Runs";
break;
}
default: {
summaryName = "Unspecific Triggers";
summaryName = "Unspecific Runs";
}
}

Expand Down

0 comments on commit d32ce87

Please sign in to comment.