[ts] make optional fields work if the key is ommited #660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uri pointed out an issue in #459
If you have a
messages
entity like so:Then using
InstaQLEntity
:You end up having an error, because typescript expects
createdAt
to be present, even though it's optionalFix
I updated how we resolved attrs, so that instead of generating:
createdAt: Foo | undefined
, we generate:createdAt?: Foo | undefined
@nezaj @dwwoelfel @tonsky