[invalidator] fix topic error from date insert #659
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw a few bugs in our logs, with the error:
Root cause
In datalog, we convert values for checked-data-type = date into java.time.Instant
topicFromQuery [:ea eid aid java.time.Instant<...>]
When we generate
topics-for-triple-insert
, we keep the underlying number value:This means that when we run
match
on the topic, this causes a type mismatchSolution
I went ahead and updated
topics-for-triple-insert
, to convert dates to java.time.InstantFurther work
Right now I realize tests for this flow are a bit cumbersome to write. Noting to look into a future PR, which could make writing something like a) Make a query, b) Make a transaction, c) see that the correct query updates, a bit easier to write
@dwwoelfel @nezaj @tonsky