Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[types] Expand should ignore builtins #654

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[types] Expand should ignore builtins #654

merged 1 commit into from
Dec 23, 2024

Conversation

stopachka
Copy link
Contributor

Nacho mentioned type issues when he put Date in his schema.

I made an example with a Date type, and realized that our Expand utility broke out the type:

I updated Expand to exclude builtin types, and my hope this will make Nacho's upgrade seamless.

@dwwoelfel @nezaj @tonsky

@stopachka stopachka changed the title [experiment] Maintain date [types] Expand should ignore builtins Dec 22, 2024
@github-actions GitHub Actions
Copy link

View Vercel preview at instant-www-js-checkd-jsv.vercel.app.

nezaj
nezaj approved these changes Dec 22, 2024
View reviewed changes
Copy link
Contributor

@nezaj nezaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌👌

@stopachka stopachka merged commit 84a3975 into main Dec 23, 2024
26 checks passed
@stopachka stopachka deleted the checkd branch December 23, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nezaj nezaj nezaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stopachka @nezaj