Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our images #638

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Our images #638

merged 7 commits into from
Dec 17, 2024

Conversation

dwwoelfel
Copy link
Contributor

@dwwoelfel dwwoelfel commented Dec 17, 2024

Adds a script to replace dropbox paper images with images that we host for the newsletter.

You can preview the images with local images, but will have to deploy the code change to production before the images will be available in production (and therefore you won't be able to send the newsletter before deploying the change).

Here's what it looks like when you preview with local images:

image

Also works with the preview: https://instant-www-js-our-images-jsv.vercel.app/intern/emails/oct2024

Copy link

View Vercel preview at instant-www-js-our-images-jsv.vercel.app.

Copy link
Contributor

@nezaj nezaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heck yeah, really appreciate this!

Made some minor tweaks. Added instructions about generating images to newsletter.clj and made the warning header not fixed so it's easier to read the preview content when scrolling

@dwwoelfel dwwoelfel merged commit 13a3782 into main Dec 17, 2024
27 checks passed
@dwwoelfel dwwoelfel deleted the our-images branch December 17, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants