-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch-Ready Strong Init #633
Conversation
View Vercel preview at instant-www-js-st1-jsv.vercel.app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Some thoughts as I went through the example:
-
The
next
link on the react docs page goes to "React native" instead of "Working with data" -
It would be nice if you didn't have to provide an empty object for
links
androoms
if you're not using those. The types will fail if you leave outrooms
, but if you leave outlinks
, we'll throw a unhelpful "TypeError: Cannot convert undefined or null to object" error.
8e018a6
to
d0840e9
Compare
update rest of sandbox update calls in dash update pages examples update dash update home page update explorer improve docs styles
Co-authored-by: Daniel Woelfel <[email protected]>
This gets strong init ready for prime time launch!
Try it out
Start by reading the docs, and follow the getting started examples:
https://instant-www-js-st1-jsv.vercel.app/docs
I went ahead and published an experimental version:
0.17.0-experimental.5
. All the tutorials will include this tag :)The PR
1. Update CLI, so
init
works withoutlogin
If the user wasn't logged in,
npx instant-cli
used to break. This led to a poor initial user experience.I updated the command so if we aren't logged in, we prompt the user to log in and continue on.
2. Make
init_experimental
the defaultI went ahead and all
packages
, so the strong init path is now the only path.What this means for users
If a user was using normal init:
Upgrading to 0.17.0 will be seamless. However, if they used to use a schema:
They'll need to do a one line change:
3. Update our docs UI
Our docs UI was feeling a bit cluttered:
I made it so:
Here's how it looks now:
4. Support for ansi rendering
I wanted to paste in what a CLI result looked like. This is a bit of a hack, but I added a custom
ansi
tag in our markdoc. It's a bit of process, but we can share the CLI output in the docs like so:5. Docs updates
I went through every page of the docs, and did updates:
6. Fixes "next page" and "previous page" in our intro sections
In our docs, when you were on the "Getting Started in React" page:
If you looked, the "Next Page" would be "Getting started in React Native".
But in reality, you would want the next page to be "Init".
I updated it so:
7. Temporarily Update docs to use 0.17.0-experimental.3
I wanted to make it easy for you to test the latest version, so included the tag on all instructions in the docs. I will remove that commit when we are ready to ship.
@nezaj @dwwoelfel @tonsky