[Storage] Add storage user #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View Vercel preview at instant-www-js-fix-expiration-jsv.vercel.app. |
dwwoelfel
reviewed
Nov 26, 2024
server/src/instant/storage/s3.clj
Outdated
| (s3/generate-presigned-url {:method :put | ||
| :bucket-name bucket-name | ||
| :key object-key}))) | ||
| (s3/generate-presigned-url |
There was a problem hiding this comment.
Could we make this optional so that people who get this working on OSS won't have to set up the access keys if they don't want to?
dwwoelfel
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still working on the storage PR but felt wanted to ship this separately to users earlier.
Created a an IAM user specifically for S3 privileges and supply it's credentials for generating signed urls