Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Increase default timeout for CLI #345

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[CLI] Increase default timeout for CLI #345

merged 1 commit into from
Oct 11, 2024

Conversation

nezaj
Copy link
Contributor

@nezaj nezaj commented Oct 11, 2024

One of our users put up a PR to increase the timeout of the CLI #318

I figured instead of making this an extra option, we can just cap it to 5 minutes, which is what Chrome uses nodejs/undici#1373

Tested this with a local backend to ensure timeouts are respected!

@nezaj nezaj force-pushed the increase-cli-timeout branch from 2147eed to 41bbea1 Compare October 11, 2024 00:03
Copy link

View Vercel preview at instant-www-js-increase-cli-timeout-jsv.vercel.app.

Copy link
Contributor

@stopachka stopachka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm!

@nezaj nezaj merged commit 76a06e3 into main Oct 11, 2024
22 checks passed
@nezaj nezaj deleted the increase-cli-timeout branch October 11, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants