Improved error messaging for conflicting link defs in schema.ts #296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema planner doesn't account for a sneaky invariant: what if the user has a link def, but in the opposite direction of one in the database? As in, the forward and reverse identities are swapped. Right now, we catch this, but throw a misleading "check your schema file for dupes" error. In this change, I add some code to check for this case, and throw a (hopefully) more informative error.
To repro - go to
sandbox/cli-nodejs/instant.schema.ts
and swap theforward
andreverse
props of one of the links.