Clusterresources refs for other clusters #625
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengu-alt
force-pushed
the
clusterresources-refs-for-other-clusters
branch
from
181a49e to
e2755e7
Compare
ribaraka
requested changes
Nov 22, 2023
Comment on lines
42
to
44
| type FirewallRuleSpec struct { | ||
| ClusterID string `json:"clusterId"` | ||
| Type string `json:"type"` | ||
| Type string `json:"type"` | ||
| } |
There was a problem hiding this comment.
How about we abandon this generic struct with only one field? There is also another one called VPCPeeringSpec
Comment on lines
29
to
31
| type ClusterBackupSpec struct { | ||
| ClusterID string `json:"clusterId"` | ||
| ClusterKind string `json:"clusterKind"` | ||
| } |
There was a problem hiding this comment.
ClusterKind you can move simply into the Status and thus you will remove and simplify the code that calculates the appropriate Kind.
Another consideration is whether triggering a backup through a cluster spec enhances the user experience. Need to ask what others think.
| } | ||
|
|
||
| type PeeringStatus struct { | ||
| ID string `json:"id,omitempty"` | ||
| StatusCode string `json:"statusCode,omitempty"` | ||
| Name string `json:"name,omitempty"` | ||
| FailureReason string `json:"failureReason,omitempty"` | ||
| CDCID string `json:"cdcid,omitempty"` |
|
AWSEndpointServicePrincipal is missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.