Skip to content

Commit

Permalink
cleanup tests
Browse files Browse the repository at this point in the history
  • Loading branch information
libretto committed Nov 13, 2024
1 parent 9cd1687 commit 52f56c0
Showing 1 changed file with 0 additions and 60 deletions.
60 changes: 0 additions & 60 deletions tests/integration/schema_registry/test_jsonschema_references.py
Original file line number Diff line number Diff line change
Expand Up @@ -311,11 +311,6 @@ async def test_schemaregistry_schemaregistry_extra_optional_field_with_open_mode
writer=A_INT_OBJECT_SCHEMA,
client=registry_async_client,
)
# await schemas_are_backward_compatible(
# reader=TRUE_SCHEMA,
# writer=A_INT_OBJECT_SCHEMA,
# client=registry_async_client,
# )
await schemas_are_backward_compatible(
reader=EMPTY_SCHEMA,
writer=A_INT_OBJECT_SCHEMA,
Expand Down Expand Up @@ -365,16 +360,6 @@ async def test_schemaregistry_schemaregistry_extra_optional_field_with_open_mode
async def test_schemaregistry_schemaregistry_extra_field_with_closed_model_is_incompatible(
registry_async_client: Client,
) -> None:
# await not_schemas_are_backward_compatible(
# reader=FALSE_SCHEMA,
# writ-er=A_INT_OBJECT_SCHEMA,
# client=registry_async_client,
# )
# await not_schemas_are_backward_compatible(
# reader=A_INT_OBJECT_SCHEMA,
# writer=FALSE_SCHEMA,
# client=registry_async_client,
# )
await not_schemas_are_backward_compatible(
reader=NOT_OF_TRUE_SCHEMA,
writer=A_INT_OBJECT_SCHEMA,
Expand Down Expand Up @@ -408,11 +393,6 @@ async def test_schemaregistry_schemaregistry_missing_required_field_is_incompati
writer=A_INT_OBJECT_SCHEMA,
client=registry_async_client,
)
# await not_schemas_are_backward_compatible(
# reader=A_INT_B_DINT_REQUIRED_OBJECT_SCHEMA,
# writer=A_INT_OBJECT_SCHEMA,
# client=registry_async_client,
# )
await not_schemas_are_backward_compatible(
reader=A_INT_OBJECT_SCHEMA,
writer=A_INT_B_DINT_REQUIRED_OBJECT_SCHEMA,
Expand All @@ -428,11 +408,6 @@ async def test_schemaregistry_giving_a_default_value_for_a_non_required_field_is
writer=A_DINT_OBJECT_SCHEMA,
client=registry_async_client,
)
# await schemas_are_backward_compatible(
# reader=TRUE_SCHEMA,
# writer=A_DINT_OBJECT_SCHEMA,
# client=registry_async_client,
# )
await schemas_are_backward_compatible(
reader=EMPTY_SCHEMA,
writer=A_DINT_OBJECT_SCHEMA,
Expand Down Expand Up @@ -470,24 +445,6 @@ async def test_schemaregistry_giving_a_default_value_for_a_non_required_field_is
)


# async def test_schemaregistry_boolean_schemas_are_backward_compatible(registry_async_client: Client) -> None:
# await not_schemas_are_backward_compatible(
# reader=FALSE_SCHEMA,
# writer=TRUE_SCHEMA,
# client=registry_async_client,
# )
# await schemas_are_backward_compatible(
# reader=TRUE_SCHEMA,
# writer=FALSE_SCHEMA,
# client=registry_async_client,
# )
# await schemas_are_backward_compatible(
# reader=FALSE_SCHEMA,
# writer=TRUE_SCHEMA,
# client=registry_async_client,
# )


async def test_schemaregistry_from_closed_to_open_is_incompatible(registry_async_client: Client) -> None:
await not_schemas_are_backward_compatible(
reader=B_NUM_C_INT_OBJECT_SCHEMA,
Expand Down Expand Up @@ -525,23 +482,6 @@ async def test_schemaregistry_array_and_tuples_are_incompatible(registry_async_c
)


# async def test_schemaregistry_true_schema_is_compatible_with_object(registry_async_client: Client) -> None:
# for schema in OBJECT_SCHEMAS + BOOLEAN_SCHEMAS:
# if schema != TRUE_SCHEMA:
# await schemas_are_backward_compatible(
# reader=TRUE_SCHEMA,
# writer=schema,
# client=registry_async_client,
# )

# for schema in NON_OBJECT_SCHEMAS:
# await not_schemas_are_backward_compatible(
# reader=TRUE_SCHEMA,
# writer=schema,
# client=registry_async_client,
# )


async def test_schemaregistry_schema_compatibility_successes(registry_async_client: Client) -> None:
# allowing a broader set of values is compatible
await schemas_are_backward_compatible(
Expand Down

0 comments on commit 52f56c0

Please sign in to comment.