Cleaning up vars, loops, etc #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
approved these changes
Oct 18, 2023
| @@ -10,7 +10,7 @@ use std::cmp; | |||
| /// # Returns | |||
| /// | |||
| /// The mean squared error, or an error message if the vector lengths are different. | |||
| pub fn calculate_error(vec1: &Vec<f64>, vec2: &Vec<f64>) -> Option<f64> { | |||
| pub fn calculate_error(vec1: &[f64], vec2: &Vec<f64>) -> Option<f64> { | |||
There was a problem hiding this comment.
heh, reviewing this again, I should have mentioned changing vec2 to &[f64] as well.
It doesnt currently affect anything though as we already have a vec to pass in for vec2 all the times we call calculate_error. Its just good practice.
Daniil-Golikov
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a few inconsistencies around variable names, function naming, etc
Also accepts the suggestions made in early PRs.