Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Compressor Settings #50

Closed
wants to merge 2 commits into from

Conversation

joshuabvarghese
Copy link
Contributor

Added CompressorSettings Struct:

A new CompressorSettings struct has been defined to hold compressor settings, which can be used to customize the compression process.
Updated process_args Function:

The process_args function now accepts an optional CompressorSettings argument, allowing users to provide custom compressor settings.
Enhanced process_directory and process_single_file Functions:

The process_directory and process_single_file functions now accept the CompressorSettings argument and use it when calling the compress_data function.
Modified compress_data Function:

The compress_data function has been updated to accept the CompressorSettings argument and utilize it when compressing data. It checks if custom settings are provided and uses them, falling back to default settings if none are provided.

@rukai
Copy link
Contributor

rukai commented Oct 16, 2023

Heads up that you have a merge conflict.

I try to avoid adding abstractions when we dont know what they will be used for. (in this case what fields will go in the struct)
If you can describe some example settings you know we will need this abstraction for that would be helpful.
Maybe this is just something carlos requested because he has something in mind for it? in which case I'm happy to just hit approve to keep things moving.

@joshuabvarghese joshuabvarghese deleted the Define-DS-for-Compressor-Settings branch October 18, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants