Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compressors working! #47

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Compressors working! #47

merged 2 commits into from
Oct 16, 2023

Conversation

cjrolo
Copy link
Collaborator

@cjrolo cjrolo commented Oct 13, 2023

This PR makes the command line work with handpicked compressors (NOOP and Constant).

Changes:

  • Add BRO file extension to output files
  • Skips optimization steps since the compressors are handpicked (Should still run through in the future)
  • Add more debug information

rukai
rukai approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me I. assume there are future plans to make use of optimiser_results_f

@cjrolo cjrolo merged commit 5d810b8 into main Oct 16, 2023
@cjrolo
Copy link
Collaborator Author

cjrolo commented Oct 16, 2023

optimiser_results_f we just a nice discussion about that this morning, and it is probably going to kill it.

@cjrolo cjrolo deleted the optimizer-optimization branch October 16, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daniil-Golikov Daniil-Golikov Daniil-Golikov approved these changes

@rukai rukai rukai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjrolo @rukai @Daniil-Golikov