utils: add get_number_of_author_matches helper #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me for the requirements we got 👍 |
|
https://travis-ci.org/inspirehep/inspire-matcher/jobs/286113042#L725 is the canonical Unicode error: now you should know how to fix that : ) |
chris-asl
force-pushed
the
add-util-get-number-of-author-matches
branch
from
a13315a to
0df5e09
Compare
jacquerie
force-pushed
the
add-util-get-number-of-author-matches
branch
from
0df5e09 to
07b0037
Compare
Adds a helper method for getting the number of author matches between two schema-compliant author lists. Sem-Ver: adds new feature Signed-off-by: Chris Aslanoglou <[email protected]>
jacquerie
force-pushed
the
add-util-get-number-of-author-matches
branch
from
07b0037 to
038efaa
Compare
jacquerie
reviewed
Oct 27, 2017
| from inspire_matcher.utils import get_number_of_author_matches | ||
|
|
||
|
|
||
| def test_get_number_of_author_matches(): |
There was a problem hiding this comment.
I simplified these tests as we are not really interested in testing here all the features that the AuthorComparator offers; these should be tested inside of inspire-json-merger (as you did in inspirehep/inspire-json-merger#27).
Bonus points if you get the inside joke : )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
given two hep-schema compliant author JSON object lists.
Signed-off-by: Chris Aslanoglou [email protected]
The build is going to fail for now. An update of
inspire-json-mergeris expected, to fix a unicode related issue.