Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

author update: generic fixes #69

Merged
merged 1 commit into from
Aug 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backoffice/backoffice/workflows/api/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ class AuthorWorkflowViewSet(viewsets.ViewSet):
serializer_class = WorkflowAuthorSerializer

@extend_schema(
summary="Create a New Author",
description="Creates a new author, launches the required airflow dags.",
summary="Create/Update an Author",
description="Creates/Updates an author, launches the required airflow dags.",
request=serializer_class,
)
def create(self, request):
drjova marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
6 changes: 3 additions & 3 deletions workflows/dags/author/author_update/author_update.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def set_author_update_workflow_status_to_running(**context):

@task()
def create_ticket_on_author_update(**context):
endpoint = "/tickets/create-with-template"
endpoint = "/api/tickets/create"
request_data = {
"functional_category": "Author updates",
"template": "curator_update_author",
Expand All @@ -80,9 +80,9 @@ def update_author_on_inspire(**context):
record_data = inspire_http_record_management_hook.get_record(
pid_type="authors", control_number=control_number
)
updated_record_data = record_data["metadata"].update(workflow_data["data"])
record_data["metadata"].update(workflow_data["data"])
response = inspire_http_record_management_hook.update_record(
data=updated_record_data,
data=record_data["metadata"],
pid_type="authors",
control_number=control_number,
revision_id=record_data["revision_id"] + 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ def update_record(
method="PUT",
headers=update_headers,
json=data,
endpoint=f"{pid_type}/{control_number}",
endpoint=f"/api/{pid_type}/{control_number}",
)

def get_record(self, pid_type: str, control_number: int) -> Response:
response = self.run_with_advanced_retry(
_retry_args=self.tenacity_retry_kwargs,
method="GET",
headers=self.headers,
endpoint=f"/{pid_type}/{control_number}",
endpoint=f"/api/{pid_type}/{control_number}",
)
return response.json()

Expand All @@ -32,7 +32,7 @@ def get_record_revision_id(self, pid_type: str, control_number: int) -> int:
_retry_args=self.tenacity_retry_kwargs,
method="GET",
headers=self.headers,
endpoint=f"/{pid_type}/{control_number}",
endpoint=f"/api/{pid_type}/{control_number}",
)
response.raise_for_status()
return response.json()["revision_id"]
Expand Down
Loading