Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant step #291

Merged
merged 1 commit into from
Nov 26, 2024
Merged

remove redundant step #291

merged 1 commit into from
Nov 26, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Nov 25, 2024

follow-up on #290

no need to clean-up assets if assets downloads is disabled

fixes errors in docs CI: https://github.com/insightsengineering/tlg-catalog/actions/runs/11989043816

Error in gzfile(file, "rb") : cannot open the connection
Calls: readRDS -> gzfile
In addition: Warning message:
In gzfile(file, "rb") :
  cannot open compressed file './book/_site/site_libs/quarto-contrib/shinylive-0.9.1/shinylive/webr/packages/metadata.rds', probable reason 'No such file or directory'
Execution halted
Error: Process completed with exit code 1.

@pawelru pawelru requested a review from shajoezhu November 25, 2024 08:57
@pawelru pawelru added the sme label Nov 25, 2024
@pawelru pawelru enabled auto-merge (squash) November 25, 2024 08:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

Unit Tests Summary

340 tests   252 ✅  1m 1s ⏱️
135 suites   88 💤
  1 files      0 ❌

Results for commit dc039d4.

♻️ This comment has been updated with latest results.

shajoezhu
shajoezhu approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! approve to allow merge

@pawelru pawelru merged commit fa9dad4 into main Nov 26, 2024
20 checks passed
@pawelru pawelru deleted the fix_docs_gha branch November 26, 2024 05:53
@shajoezhu
Copy link
Contributor

thanks @pawelru

@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shajoezhu shajoezhu shajoezhu approved these changes

Assignees
No one assigned
Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawelru @shajoezhu