-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace webr extension; upkeep #287
Conversation
Unit Tests Summary340 tests 252 ✅ 1m 2s ⏱️ Results for commit 6f13578. ♻️ This comment has been updated with latest results. |
A hit for the reviewer: please don't focus on the changes in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @pawelru , lgtm! approve to unblock merge
r-wasm/quarto-live
withcoatless/webr
- close Switch tor-wasm/quarto-live
#281{webr-r}
into{webr}
_quarto.yaml
html
intolive-html
live-html
webr code chunks has access to previous webr code chunks. Therefore we don't have to include "setup" chunks in the webr code chunks. That reduces the amount of code the user sees which is a nice feature.## Output
- to prepare for extending catalog with cards - so that it would be easier to add new child sections inside Outputs<!-- ... --!>
) as these are pushed to the output HTML documentwarning = FALSE, message = FALSE
to the startup code chunks to hide package startup messageswebr_code_labels
) to multiline code chunk so that it won't be changed by IDE autoformatters. This was already detected previously and apparently in this case the spaces matter so it would prevent auto-destroys in the future