Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace webr extension; upkeep #287

Merged
merged 7 commits into from
Nov 20, 2024
Merged

replace webr extension; upkeep #287

merged 7 commits into from
Nov 20, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Nov 14, 2024

  • replace r-wasm/quarto-live with coatless/webr - close Switch to r-wasm/quarto-live #281
    • remove one extension
    • add another one
    • slightly change css - there is a new div ID
    • updates webr code chunks -> {webr-r} into {webr}
    • update webr config options in _quarto.yaml
    • change the format from html into live-html
    • live-html webr code chunks has access to previous webr code chunks. Therefore we don't have to include "setup" chunks in the webr code chunks. That reduces the amount of code the user sees which is a nice feature.
  • Other changes:
    • fixes layout error - close [bug] mmrmg01 not rendering  #285
    • apply full width
    • apply auto-formatting from VSCode quarto extension
    • add ## Output - to prepare for extending catalog with cards - so that it would be easier to add new child sections inside Outputs
    • remove Quarto comments (i.e. <!-- ... --!>) as these are pushed to the output HTML document
    • add warning = FALSE, message = FALSE to the startup code chunks to hide package startup messages
    • change inline r code chunk (with webr_code_labels) to multiline code chunk so that it won't be changed by IDE autoformatters. This was already detected previously and apparently in this case the spaces matter so it would prevent auto-destroys in the future
    • review all existing skips - skip strict, skip tests, skip eval

@pawelru pawelru added the sme label Nov 14, 2024
Copy link
Contributor

github-actions bot commented Nov 14, 2024

Unit Tests Summary

340 tests   252 ✅  1m 2s ⏱️
135 suites   88 💤
  1 files      0 ❌

Results for commit 6f13578.

♻️ This comment has been updated with latest results.

@pawelru
Copy link
Contributor Author

pawelru commented Nov 15, 2024

A hit for the reviewer: please don't focus on the changes in _extensions subdirectory. This is the code that we import via Quarto extensions. I have not write this on my own. When using an extension, Quarto actually download it's code to the child directory of the book so here it is.

@shajoezhu shajoezhu self-assigned this Nov 18, 2024
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @pawelru , lgtm! approve to unblock merge

@pawelru pawelru merged commit 6d18058 into main Nov 20, 2024
20 checks passed
@pawelru pawelru deleted the webr_ext branch November 20, 2024 09:06
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] mmrmg01 not rendering Switch to r-wasm/quarto-live
2 participants