Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close #272 #273

Closed
wants to merge 3 commits into from
Closed

close #272 #273

wants to merge 3 commits into from

Conversation

shajoezhu
Copy link
Contributor

No description provided.

@shajoezhu shajoezhu added the sme label Oct 14, 2024
@shajoezhu shajoezhu requested a review from pawelru October 14, 2024 02:55
Copy link
Contributor

github-actions bot commented Oct 14, 2024

Unit Tests Summary

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
1 files    0 ❌

Results for commit 586d292.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 14, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
graph-snaps 💀 $4.22$ $-4.22$ $-42$ $-42$ $0$ $0$
markdown-snaps 💀 $52.33$ $-52.33$ $-253$ $-253$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
graph-snaps 💀 $0.17$ $-0.17$ unnamed
graph-snaps 💀 $3.25$ $-3.25$ plot_v1
graph-snaps 💀 $0.39$ $-0.39$ plot_v2
graph-snaps 💀 $0.09$ $-0.09$ plot_v3
graph-snaps 💀 $0.09$ $-0.09$ plot_v4
graph-snaps 💀 $0.07$ $-0.07$ plot_v5
graph-snaps 💀 $0.07$ $-0.07$ plot_v6
graph-snaps 💀 $0.03$ $-0.03$ plot_v7
graph-snaps 💀 $0.03$ $-0.03$ plot_v8
graph-snaps 💀 $0.03$ $-0.03$ plot_v9
markdown-snaps 💀 $1.32$ $-1.32$ lsting
markdown-snaps 💀 $26.21$ $-26.21$ result_v1
markdown-snaps 💀 $0.17$ $-0.17$ result_v10
markdown-snaps 💀 $0.46$ $-0.46$ result_v11
markdown-snaps 💀 $0.10$ $-0.10$ result_v12
markdown-snaps 💀 $0.08$ $-0.08$ result_v13
markdown-snaps 💀 $8.83$ $-8.83$ result_v2
markdown-snaps 💀 $5.69$ $-5.69$ result_v3
markdown-snaps 💀 $4.58$ $-4.58$ result_v4
markdown-snaps 💀 $2.59$ $-2.59$ result_v5
markdown-snaps 💀 $0.92$ $-0.92$ result_v6
markdown-snaps 💀 $0.22$ $-0.22$ result_v7
markdown-snaps 💀 $0.69$ $-0.69$ result_v8
markdown-snaps 💀 $0.48$ $-0.48$ result_v9

Results for commit 2b7f995

♻️ This comment has been updated with latest results.

@shajoezhu shajoezhu enabled auto-merge (squash) October 14, 2024 06:55
@pawelru
Copy link
Contributor

pawelru commented Oct 18, 2024

There are still notes reported in CI:

* checking for portable file names ... NOTE
Found the following non-portable file paths:
  tlg.catalog.pkg/tests/testthat/_book/_extensions/quarto-ext/fontawesome/assets/css/latex-fontsize.css
  tlg.catalog.pkg/tests/testthat/_book/_extensions/quarto-ext/shinylive/resources/css/shinylive-quarto.css

Tarballs are only required to store paths of up to 100 bytes and cannot
store those of more than 256 bytes, with restrictions including to 100
bytes for the final component.
See section ‘Package structure’ in the ‘Writing R Extensions’ manual.

@pawelru pawelru self-assigned this Oct 18, 2024
Copy link
Contributor

@pawelru pawelru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not there yet - see my previous comment

@m7pr
Copy link
Contributor

m7pr commented Oct 18, 2024

@pawelru
Copy link
Contributor

pawelru commented Oct 25, 2024

Warning is weird as the folder is empty https://github.com/insightsengineering/tlg-catalog/blob/main/package/tests/testthat/_book

No it's not. This is how GitHub present symlinks

@pawelru
Copy link
Contributor

pawelru commented Oct 25, 2024

Went with an alternative #274

@pawelru pawelru closed this Oct 25, 2024
auto-merge was automatically disabled October 25, 2024 13:27

Pull request was closed

@pawelru pawelru deleted the 272_Rbuildignore branch October 25, 2024 13:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants