-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix snaps #254
Conversation
Unit Tests Summary341 tests 253 ✅ 1m 0s ⏱️ Results for commit 3eb378c. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceTest suite performance difference
Additional test case details
Results for commit 071813b ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! I would not get stuck with these precision changes. I think we did not fix everything here for snapshots testing as we did in scda.test, hence probably the precision misalignment. Thanks Pawel for fixing this!
No description provided.