Update index categories #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lg-catalog into 123_fix_index@main
|
@ayogasekaram I think it duplicated the folders instead of renaming when you converted to uppercase (see here) - the lowercase versions should be deleted and then I think it should be good to go :) |
Signed-off-by: Emily de la Rua <[email protected]>
Signed-off-by: Emily de la Rua <[email protected]>
Signed-off-by: Emily de la Rua <[email protected]>
Signed-off-by: Emily de la Rua <[email protected]>
edelarua
requested changes
Sep 21, 2023
adding code review suggestions Co-authored-by: Emily de la Rua <[email protected]> Signed-off-by: Abinaya Yogasekaram <[email protected]>
edelarua
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Hi @ayogasekaram, I think some files accidentally got deleted so I restored those and you're good to merge now! Thanks!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #123
related to #57