-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace usage of scda
and scda.2022
with random.cdisc.data
#250
Conversation
CLA Assistant Lite bot ✅ All contributors have signed the CLA |
I have read the CLA Document and I hereby sign the CLA |
Unit Test Performance DifferenceTest suite performance difference
Additional test case details
Results for commit 9a5284a ♻️ This comment has been updated with latest results. |
Unit Tests Summary341 tests 0 ✅ 55s ⏱️ Results for commit 5b4e36e. ♻️ This comment has been updated with latest results. |
I have gone through all of the tables and all the dataset related changes are ok. You also included fee text as well as DESC and others - that's awesome. Let's just fix the layout and then it's good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Great work Abi ;) I still need to render it on my local but it seems perfectly fine (all latest pulls anyway from scda)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ii was waiting for this PR to happen. Thank you for it!
closes #242
similar to this PR