Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Signed-off-by: Pawel Rucki <[email protected]>
  • Loading branch information
pawelru authored Nov 4, 2024
1 parent 03de19b commit dc95505
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 29 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
r-cmd-dev:
if: github.event_name != 'push'
name: R CMD Check (development) 🧬
uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@bci_params
uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@main
secrets:
REPO_GITHUB_TOKEN: ${{ secrets.REPO_GITHUB_TOKEN }}
with:
Expand Down Expand Up @@ -58,7 +58,7 @@ jobs:
r-cmd-stable:
if: github.event_name != 'push'
name: R CMD Check (stable) 🧬
uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@bci_params
uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@main
secrets:
REPO_GITHUB_TOKEN: ${{ secrets.REPO_GITHUB_TOKEN }}
with:
Expand Down
53 changes: 26 additions & 27 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ on:
push:
branches:
- main
- use_setup_r_deps
schedule:
- cron: "17 17 * * 3,6"

Expand Down Expand Up @@ -121,20 +120,20 @@ jobs:
saveRDS(new_metadata, metadata_path)
shell: Rscript {0}

#- name: Publish docs 📔
# uses: peaceiris/actions-gh-pages@v3
# with:
# github_token: ${{ secrets.GITHUB_TOKEN }}
# publish_dir: ./book/_site
# destination_dir: development
- name: Publish docs 📔
uses: peaceiris/actions-gh-pages@v3
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
publish_dir: ./book/_site
destination_dir: development

#- name: GChat notification 🔔
# if: (failure() || cancelled()) && env.gchat_webhook != ''
# uses: insightsengineering/google-chat-notification@master
# with:
# name: ${{ github.event.repository.name }} - development
# url: ${{ secrets.GCHAT_WEBHOOK }}
# status: ${{ job.status }}
- name: GChat notification 🔔
if: (failure() || cancelled()) && env.gchat_webhook != ''
uses: insightsengineering/google-chat-notification@master
with:
name: ${{ github.event.repository.name }} - development
url: ${{ secrets.GCHAT_WEBHOOK }}
status: ${{ job.status }}

publish-stable:
name: Build & Deploy TLGC (stable) 📖
Expand Down Expand Up @@ -213,20 +212,20 @@ jobs:
name: site-stable
path: site.zip

#- name: Publish docs 📔
# uses: peaceiris/actions-gh-pages@v3
# with:
# github_token: ${{ secrets.GITHUB_TOKEN }}
# publish_dir: ./book/_site
# destination_dir: stable
- name: Publish docs 📔
uses: peaceiris/actions-gh-pages@v3
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
publish_dir: ./book/_site
destination_dir: stable

#- name: GChat notification 🔔
# if: (failure() || cancelled()) && env.gchat_webhook != ''
# uses: insightsengineering/google-chat-notification@master
# with:
# name: ${{ github.event.repository.name }} - stable
# url: ${{ secrets.GCHAT_WEBHOOK }}
# status: ${{ job.status }}
- name: GChat notification 🔔
if: (failure() || cancelled()) && env.gchat_webhook != ''
uses: insightsengineering/google-chat-notification@master
with:
name: ${{ github.event.repository.name }} - stable
url: ${{ secrets.GCHAT_WEBHOOK }}
status: ${{ job.status }}

upload-release-assets:
name: Upload assets 🔼
Expand Down

0 comments on commit dc95505

Please sign in to comment.